593452 - Remove the Maemo back button from the toolbar for Android

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

We don't need the Maemo back button for Android. The hardware back button works the same way and is more appropriate for the platform.

Just need a #ifndef ANDROID/#endif in the right spots.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch uses the preprocessor to remove the tool-app-close button (app close and back) from all platforms except Maemo. The same logic we use for the tool-app-switch button (task switcher).

The patch also uses preprocessor to remove the CSS for those buttons as well. Less CSS is better.

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 471962 [details] [diff] [review]
patch

r=mbrubeck

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/8634ec07ce92

Comment 4

[Aakash Desai [:aakashd]]

I'm still seeing the maemo back button on build:

Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b6pre)
Gecko/20100908 Namoroka/4.0b6pre Fennec/2.0b1pre

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Sounds like the build was busted and is being respun

Comment 6

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b6pre) Gecko/20100909 Namoroka/4.0b6pre Fennec/2.0b1pre

Comment 7

[Ayan Shah[:ashah]]

Litmus test case added:

https://litmus.mozilla.org/show_test.cgi?id=13535