Closed Bug 593452 Opened 10 years ago Closed 10 years ago

Remove the Maemo back button from the toolbar for Android

Categories

(Firefox for Android Graveyard :: General, defect)

x86
macOS
defect
Not set

Tracking

(fennec2.0b1+)

VERIFIED FIXED
Tracking Status
fennec 2.0b1+ ---

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

We don't need the Maemo back button for Android. The hardware back button works the same way and is more appropriate for the platform.

Just need a #ifndef ANDROID/#endif in the right spots.
Assignee: nobody → wjohnston
tracking-fennec: --- → 2.0b1+
Assignee: wjohnston → mark.finkle
Attached patch patchSplinter Review
This patch uses the preprocessor to remove the tool-app-close button (app close and back) from all platforms except Maemo. The same logic we use for the tool-app-switch button (task switcher).

The patch also uses preprocessor to remove the CSS for those buttons as well. Less CSS is better.
Attachment #471962 - Flags: review?(mbrubeck)
Comment on attachment 471962 [details] [diff] [review]
patch

r=mbrubeck
Attachment #471962 - Flags: review?(mbrubeck) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/8634ec07ce92
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
I'm still seeing the maemo back button on build:

Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b6pre)
Gecko/20100908 Namoroka/4.0b6pre Fennec/2.0b1pre
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Sounds like the build was busted and is being respun
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
verified FIXED on builds:
Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b6pre) Gecko/20100909 Namoroka/4.0b6pre Fennec/2.0b1pre
Status: RESOLVED → VERIFIED
Flags: in-litmus?
Assignee: mark.finkle → ayanshah62
Assignee: ayanshah62 → mark.finkle
Flags: in-litmus? → in-litmus?(ayanshah62)
Litmus test case added:

https://litmus.mozilla.org/show_test.cgi?id=13535
Flags: in-litmus?(ayanshah62) → in-litmus+
You need to log in before you can comment on or make changes to this bug.