Closed Bug 593456 Opened 9 years ago Closed 9 years ago

Only support the two-tap URLBar edit mode in Landscape

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(fennec2.0b1+)

VERIFIED FIXED
Tracking Status
fennec 2.0b1+ ---

People

(Reporter: mfinkle, Assigned: vingtetun)

Details

Attachments

(1 file)

Since the virtual keyboard displayed when in landscape mode is completely obtrusuive, we want to keep the two-tap edit mode behavior in that situation.

In portrait mode however, we have more space and a less obtrusive virtual keyboard. We want to change back to a single-tab edit mode for portrait mode.
OS: Mac OS X → All
Hardware: x86 → All
tracking-fennec: --- → 2.0b1+
Assignee: nobody → 21
Comment on attachment 473112 [details] [diff] [review]
Patch

>diff -r 078449f88da5 chrome/content/browser-ui.js

>         gFocusManager.setFocus(this._edit, Ci.nsIFocusManager.FLAG_NOSCROLL);
>       }
>-
>-      this._edit.readOnly = !isOpened;
>+      else
>+        this._edit.readOnly = !isOpened;

nit: needs { } around the else
Attachment #473112 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/84b366c27af8
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
verified FIXED on builds:
Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b6pre) Gecko/20100909 Namoroka/4.0b6pre Fennec/2.0b1pre

and

Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b6pre) Gecko/20100909 Namoroka/4.0b6pre Fennec/2.0b1pre
Status: RESOLVED → VERIFIED
Flags: in-litmus?
Assignee: 21 → nhirata.bugzilla
Assignee: nhirata.bugzilla → 21
Flags: in-litmus? → in-litmus?(nhirata.bugzilla)
Bug 591955 shows that this is no longer working.  Setting this bug to - and bug 591955 to ?
Flags: in-litmus?(nhirata.bugzilla) → in-litmus-
You need to log in before you can comment on or make changes to this bug.