593483 - Unbreak (real) dtrace

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

Compiling with --enable-dtrace no longer works. Bug 584175 broke it by const-ipating some parameters.

This results from a bug in dtrace. See http://web.archiveorange.com/archive/v/ejz8xyzxv3yAawGtOdTp for a brief discussion. Ironically, systemtap's dtrace emulation does the correct thing.

I have filed a bug with apple on this: https://bugreport.apple.com/cgi-bin/WebObjects/RadarWeb.woa/11/wo/bUtX4S1OlMcPZTe3nf4b2g/16.60

Comment 1

[Steve Fink [:sfink] [:s:]]

I'll take a stab at working around this with build hackery. I hate to mess up the source for it.

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Add const to char * params in probes

This patch fixes the compile on OSX.

I added const where appropriate to the .d file, which won't do anything for systemtap's dtrace because it already uses const for everything. And it won't do anything for Solaris or OSX dtrace because they incorrectly ignore it.

I also hacked the makefile to force a const unless it's already there. This has no effect with systemtap's dtrace, and fixes the problem with OSX's.

Comment 4

[Phil Ringnalda (:philor)]

Since (pending bug 595718) the Shark nightlies don't show up on tbpl, it's not obvious, but this bug means we have a permanently red build on both tracemonkey and mozilla-central now.

I'd be happy to be told that's not a blocker, because we don't care about those builds, in which case I'll just hide them on tinderbox, and they can burn in peace.

Comment 5

[Brendan Eich [:brendan]]

This has a patch, it's an easy bug to fix, we want shark builds and non-red tbox for 'em. Suspect peterv is busy, maybe try gal for review?

/be

Comment 6

[Steve Fink [:sfink] [:s:]]

Comment on attachment 472005 [details] [diff] [review]
Add const to char * params in probes

Got a mid-air collision on a comment asking for advice on an alternative reviewer. I'm glad brendan is psychic. Thanks!

Comment 7

[Andreas Gal :gal]

Comment on attachment 472005 [details] [diff] [review]
Add const to char * params in probes

NPOTB. No approval needed IMO.

Comment 8

[Steve Fink [:sfink] [:s:]]

FYI: My Apple bug has been closed as a duplicate of a known issue 5586154. Unfortunately, they only allow viewing of your own bugs, so I can't track the status.

Comment 9

[[e-mail]]

http://hg.mozilla.org/mozilla-central/rev/1a7b01521bcd