If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Make Image hold onto its URI

RESOLVED FIXED

Status

()

Core
ImageLib
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

we need this to log errors to the console in bug 514033.

It would be nice to hold onto a concrete imgRequest pointer, but unfortunately we use a weak reference to prevent cycles, and you can't get a concrete class out of a weak reference.
Created attachment 471999 [details] [diff] [review]
patch v1

Added a patch. Flagging joe for review.
Attachment #471999 - Flags: review?(joe)
Blocks: 514033
Attachment #471999 - Flags: review?(joe) → review+
Created attachment 474434 [details] [diff] [review]
patch v2

Rebased. Carrying over review.
Attachment #471999 - Attachment is obsolete: true
Attachment #474434 - Flags: review+
Pushed to mozilla-central:

http://hg.mozilla.org/mozilla-central/rev/dbdd01fabe45

Resolving fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.