Closed Bug 593499 Opened 9 years ago Closed 9 years ago

Increase the double-tap thresholds

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
It's hard to double-tap in Fennec because the thresholds (max 200ms and 32px between taps) are so small.

The Android platform uses 300ms and 100px as its thresholds.  Perhaps ideally we should use the OS double-tap detection to fit in on different platforms, but as a simple change we can increase our thresholds to match Android's.
Attachment #472002 - Flags: review?(mark.finkle)
Comment on attachment 472002 [details] [diff] [review]
patch

Looks OK for general landing. If something starts to feel strange on Maemo, we can adjust per-platform.
Attachment #472002 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/aeb8aa5a377f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Some of these changes did not do what I intended them too, because I misunderstood the meaning of the kDoubleClickThreshold constant.  The constant that's relevant for this bug is kDoubleClickInterval, which is already set to 400ms.

This patch rolls back changes to the click timing constants, and clarifies the comments a bit.
Attachment #472002 - Attachment is obsolete: true
Attachment #473173 - Flags: review?(webapps)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #473173 - Flags: review?(webapps) → review+
http://hg.mozilla.org/mobile-browser/rev/6c3b8ad68d56
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
Looks good to me on verification, but I'm not a good judge of telling the difference between 200ms and 300ms as compared to a unit test. *wink**wink* *nudge**nudge*
You need to log in before you can comment on or make changes to this bug.