Closed Bug 593518 Opened 9 years ago Closed 9 years ago

Fix "null" appearing as title in Google Reader sharing

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Steps to reproduce:
1. Share an item with no title (e.g. most images)
2. Choose "Google Reader"

Actual results: Title field is pre-filled the string "null"
Expected results: Title field is empty
Attachment #472042 - Flags: review?(mark.finkle)
Comment on attachment 472042 [details] [diff] [review]
patch

>diff -r 3de68a96cf62 chrome/content/browser-ui.js
>-        handler.callback(aURL, aTitle);
>+        handler.callback(aURL||"", aTitle||"");

nit: spaces around operators
Attachment #472042 - Flags: review?(mark.finkle) → review+
Pushed with whitespace fixed:
http://hg.mozilla.org/mobile-browser/rev/e99b08663309
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
verified FIXED on build:
Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b6pre) Gecko/20100907 Namoroka/4.0b6pre Fennec/2.0b1pre

and

Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b6pre) Gecko/20100907 Namoroka/4.0b6pre Fennec/2.0b1pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.