Closed
Bug 59353
Opened 24 years ago
Closed 19 years ago
Remove "used only once fix" sillyness from CGI.pl
Categories
(Bugzilla :: Bugzilla-General, enhancement)
Bugzilla
Bugzilla-General
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: jvromans, Unassigned)
References
Details
(Whiteboard: [blocker will fix])
Attachments
(1 file)
15.47 KB,
patch
|
jouni
:
review-
|
Details | Diff | Splinter Review |
This is the second patch to remove the sillyness from bugzilla. See the remarks for bug 59352. This patch removes the sillyness from CGI.pl, being the other of the two central files. Patches for other files will follow in due time. Note that the fixes for each of the files are independent of each other. Also note that this patch will make all global variables owned by the current package. The old implementation forced them all to the main package. Since CGI.pl is always used (as far as I can see) from the main package, this change should be transparant.
Reporter | ||
Comment 1•24 years ago
|
||
Updated•24 years ago
|
Comment 2•23 years ago
|
||
Does this actually not break things? I may just be confused here, but I was under the impression that a mess of the variables created by this file need to be globals so the other files can all see them. Don't the changes here make them local to this file?
Reporter | ||
Comment 3•23 years ago
|
||
I checked with the sources and verified that the global variables remained global. It works in my installation. However, I stopped putting any efforts in it due to a lack of response from the bugzilla community, and the rumours that a complete rewrite is already in process.
Comment 4•23 years ago
|
||
Don't let the lack of comment discourage you. Bugzilla 3.0 is a LONG way away yet (they're doing a thorough design job, I'm betting on at least a year before it's out). And there's a LOT of bugs/feature requests being filed for Bugzilla 2.x, so it's hard to keep up, let alone add comments, sometimes :-) Anyway, back to the bug... What version of Perl are you using? Is it 5.6? Does it still work the same in 5.005? As I recall, the variables were defined as "my" originally, and we had to change them to globals when 5.6 came out to retain compatibility. Then again, it could be just something screwy was being done at the time. CCing Terry for comment, since he put the sillyness in there to begin with. He'll be able to tell us what the reasoning behind it was.
Comment 5•23 years ago
|
||
The silliness is there because I didn't completely understand the perl variable model, and it was the only way I could find to make the warnings shut up. I understand the model a bit better now, but don't claim to be an expert.
Updated•23 years ago
|
Whiteboard: 2.14
Updated•23 years ago
|
Whiteboard: 2.14 → 2.16
Comment 7•23 years ago
|
||
-> Bugzilla product, General component, reassigning.
Assignee: tara → justdave
Component: Bugzilla → Bugzilla-General
Product: Webtools → Bugzilla
Whiteboard: 2.16
Version: other → unspecified
Comment 8•23 years ago
|
||
We are currently trying to wrap up Bugzilla 2.16. We are now close enough to release time that anything that wasn't already ranked at P1 isn't going to make the cut. Thus this is being retargetted at 2.18. If you strongly disagree with this retargetting, please comment, however, be aware that we only have about 2 weeks left to review and test anything at this point, and we intend to devote this time to the remaining bugs that were designated as release blockers.
Target Milestone: Bugzilla 2.16 → Bugzilla 2.18
Comment 9•22 years ago
|
||
Won't this die because of the |requir|ing we do, rather than use? global vars suck...
Updated•21 years ago
|
Attachment #18862 -
Flags: review?
Comment 10•21 years ago
|
||
Comment on attachment 18862 [details] [diff] [review] Patch to remove sillyness from CGI.pl Gods this is old code :) From year 2000... Guess how cleanly it patches.
Attachment #18862 -
Flags: review? → review-
Comment 11•20 years ago
|
||
All 2.18 bugs that haven't been touched in over 60 days and aren't flagged as blockers are getting pushed out to 2.20
Target Milestone: Bugzilla 2.18 → Bugzilla 2.20
Updated•19 years ago
|
Severity: normal → enhancement
OS: Linux → All
Hardware: PC → All
Summary: Remove sillyness from CGI.pl → Remove "used only once fix" sillyness from CGI.pl
Updated•19 years ago
|
Assignee: justdave → general
Depends on: bz-globals
Priority: P3 → --
QA Contact: mattyt-bugzilla → default-qa
Whiteboard: [blocker will fix]
Target Milestone: Bugzilla 2.20 → ---
Comment 12•19 years ago
|
||
Basically now unnecessary (so WFM) by blocker.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•