Closed Bug 593570 Opened 13 years ago Closed 13 years ago

reduce the tab close button's impact on the tab height

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 4.0b7

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: polish)

Attachments

(2 files)

patch
2.34 KB, patch
Gavin
: review+
Gavin
: approval2.0+
Details | Diff | Splinter Review
Screenshot
10.10 KB, image/png
Details
Attached patch patch — — Splinter Review 
      No description provided.
Attachment #472135 - Flags: review?(gavin.sharp)
Attachment #472135 - Flags: review?(gavin.sharp) → review+
Blocks: 593591
http://hg.mozilla.org/mozilla-central/rev/47724f6fd67d
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6
Attached image Screenshot — 
In today's nightly, app tabs don't look correct: they seem to be 2px short because they don't "touch" the bottom and a line is visible even on active app tabs (see screenshot).

To me it kind of looks like that app tabs now have the *correct* size but the tabs are still a bit too big and force the bigger size.
(In reply to comment #2)
> Created attachment 472266 [details]
> Screenshot
> 
> In today's nightly, app tabs don't look correct: they seem to be 2px short
> because they don't "touch" the bottom and a line is visible even on active app
> tabs (see screenshot).

Could you please file a new bug?
(In reply to comment #3)
> (In reply to comment #2)
> > Created attachment 472266 [details] [details]
> > Screenshot
> > 
> > In today's nightly, app tabs don't look correct: they seem to be 2px short
> > because they don't "touch" the bottom and a line is visible even on active app
> > tabs (see screenshot).
> 
> Could you please file a new bug?

I filed bug 593690.
You need to log in before you can comment on or make changes to this bug.