593591 - Tabs too high in GTK theme mode with tabs on tab

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Michael Monreal [:micmon]]

Attachment: Screenshot

After the new tabs look landed on linux, tabs are too high. This can best be seen on the attached screenshot: there are three pixels from the favicon to the top border but 6 pixels to the bottom border. This way, the fav icon does not look centered.

Comment 1

[Michael Monreal [:micmon]]

This is much better now, only 3px (top) vs 4px (bottom).

Somewhat related, I filed bug #594922 which describes a more serious problem with tab sizing. Maybe after fixing that, fixing this will be easy as well.

Comment 2

[Michael Monreal [:micmon]]

Re-tested this and found and important things: the issue ONLY affects GTK theme mode with tabs-on-top. Using a persona theme, the size is fine. Using GTK theme and tabs-on-bottom, the size seems to be fine, too.

To test, set tabs on top with GTK theme and then switch to a persona: the awesome bar etc shift up a little (the whole area becomes less tall). This is not the case with tabs-on-bottom.

Comment 3

[Dão Gottwald [:dao]]

This shouldn't be an issue anymore.