Design and implement updated CSS styling for Linux

VERIFIED FIXED in Firefox 4.0

Status

defect
P1
normal
VERIFIED FIXED
9 years ago
3 years ago

People

(Reporter: mitcho, Assigned: shorlander)

Tracking

Trunk
Firefox 4.0
All
Linux

Firefox Tracking Flags

(blocking2.0 -)

Details

(Whiteboard: [good first bug][visual])

Attachments

(3 attachments, 2 obsolete attachments)

Bug 590742 implemented updated CSS styling for Mac OS X and Windows, based on a new design direction by Sean Martell.

This bug is to design and implement updated tabview styling for gnomestripe.

For reference, here are the CSS mockups for Mac and Win that were used:

http://mozilla.seanmartell.com/tabcandy/index.html
http://mozilla.seanmartell.com/tabcandy/index-win2.html
Priority: -- → P1
Target Milestone: Firefox 4.0b7 → ---
Blocks: 597043
Assignee: nobody → aza

Updated

9 years ago
blocking2.0: --- → ?
Whiteboard: [good first bug] → [good first bug][visual][b9]
Target Milestone: --- → Firefox 4.0

Updated

9 years ago
Blocks: 598154
No longer blocks: 597043

Updated

9 years ago
Assignee: aza → nobody
OS: Linux → Windows CE
Platform should be changed to "Linux" right ? ;-)

Updated

9 years ago
OS: Windows CE → Linux
Hardware: x86 → All
blocking2.0: ? → betaN+

Comment 2

9 years ago
Assigning to Aza to get the ball rolling.
Assignee: nobody → aza

Comment 3

9 years ago
We're not going to block on this, it's good enough as it is.
blocking2.0: betaN+ → -

Updated

8 years ago
Assignee: aza → faaborg

Comment 4

8 years ago
Assigning this to Faaborg as he'll be taking over in my absence.

Comment 5

8 years ago
bugspam (moving b9 to b10)
Blocks: 608028

Comment 6

8 years ago
bugspam (removing b9)
No longer blocks: 598154
Shorlander, Sean, Alex, will this happen for Firefox 4?
Blocks: 627096
No longer blocks: 608028
Keywords: ux-feedback
I actually have no idea what panorama looks like on Linux at the moment.  Shorlander: do we have any mockups for Linux yet.  If not I can try to work on some.
Posted image Current Linux theme
This is what panorama currently looks like on linux. We currently noticed that there is no highlighting for selected tabs (!). I didn't even know what this was until I saw a Mac screenshot.
so hard coded OS X colors throughout? (or is your OS theme just very grey :)
I'm using Ubuntu 10.10. That looks a _lot_ like OS X :)
Posted image Panorama with System Colors (obsolete) —
(In reply to comment #10)
> so hard coded OS X colors throughout? (or is your OS theme just very grey :)

It has hardcoded colors throughout for the most part. It doesn't really look that bad on most themes I tried.

A fairly simple patch could give us something more adaptable though.
Posted patch Linux Panorama Styling - 01 (obsolete) — Splinter Review
Quick update to remove the hardcoded colors and use system theme colors and fonts instead.
Attachment #506664 - Flags: review?(ian)
Assignee: faaborg → shorlander
Status: NEW → ASSIGNED
Comment on attachment 506664 [details] [diff] [review]
Linux Panorama Styling - 01

Looks great, thanks for doing this!

One question: are there perf implications to having the entire background be a gradient with transparency?
Attachment #506664 - Flags: review?(ian) → review+
CC-ing roc for his perspective on comment 15
Yes, but it'll depend on the X server and video drivers.
I'd say just go with it. I think there are decent optimizations already in place for a simple vertical gradient like this.
Comment on attachment 506664 [details] [diff] [review]
Linux Panorama Styling - 01

Looks good, especially the font is much clearer.
Attachment #506664 - Flags: feedback+
Keywords: helpwanted, uiwanted
Whiteboard: [good first bug][visual][b9] → [good first bug][visual]
Attachment #506664 - Flags: approval2.0? → approval2.0+
Stephen, I took the liberty of wrapping this up real quick.
Attachment #506664 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed http://hg.mozilla.org/mozilla-central/rev/6dbe10320e8a
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
verified with minefield build of 20110217
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.