593620 - Starting autoscroll and releasing middle button over a linked image causes link activation

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Sid]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b6pre) Gecko/20100904 Firefox/4.0b6pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b6pre) Gecko/20100904 Firefox/4.0b6pre

Starting autoscroll and releasing middle button over a linked image causes link activation

Reproducible: Always

Steps to Reproduce:
1. Go to http://pastehtml.com/view/1awm2fj.html
2. Place mouse pointer over the text, press middle button and begin autoscroll down.
3. When pointer is over "Thunderbird Logo" image (it will change from arrow into hand), release middle button.
Actual Results:  
Link is activated (www.mozilla.org opens in a new tab).

Expected Results:  
Nothing should happen.

Comment 1

[Alexander L. Slovesnik]

Confirmed.

Comment 2

[Please Ignore This Troll (Account Disabled)]

Duplicate of bug 593210

Comment 3

[Alice0775 White]

Regression window:
Works:
http://hg.mozilla.org/mozilla-central/rev/1065142ddb2c
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100901 Firefox/4.0b6pre ID:20100901200414
Fails:
http://hg.mozilla.org/mozilla-central/rev/5a051c65160e
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100901 Firefox/4.0b6pre ID:20100901210607
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1065142ddb2c&tochange=5a051c65160e
Regressed by:
Bug 590819 - Click event isn't fired when mouse button down on border of <input> and mouse button up on padding box of it

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Wow, this must be a simple mistake, thanks for the report!

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.0

just typo of the variables...

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 472636 [details] [diff] [review]
Patch v1.0

Sorry, I should have noticed this when reviewing the original patch.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

http://hg.mozilla.org/mozilla-central/rev/e42dc81d7cf5
-> FIXED

(In reply to comment #7)
> Comment on attachment 472636 [details] [diff] [review]
> Patch v1.0
> 
> Sorry, I should have noticed this when reviewing the original patch.

It's my fault, I'm sorry and thanks for the rereview.

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

oops, sorry for the spam.

Comment 10

[Gary [:streetwolf52]]

Problem hasn't been fixed.  I still go to the link instead of auto scroll.

Unless I didn't pick it up in the latest hourly... cset cd7d65bf8154


Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100907 Firefox/4.0b6pre - Build ID: 20100908075931

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Hmm, cd7d65bf8154 should have the fix.

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

> Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100907

09/07??

Comment 13

[Gary [:streetwolf52]]

(In reply to comment #12)
> > Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100907
> 
> 09/07??

I think someone decided to make it this way.  It was a Bug fix I believe.

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I tested with following test build (zip).
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/1283957971/

But I cannot reproduce this bug, are you sure the testing build is the new build?

Comment 15

[Gary [:streetwolf52]]

Tried it in safemode and still have the problem.  Created a new profile and it works as you fixed it.  Could be DW/D2D or maybe layers which are all enabled on my production Fx.  I'll try disabling stuff and see if I can get it to work.

Comment 16

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Um, any prefs except changing middle click behavior don't affect this behavior.

Can you reproduce this bug before the fix of bug 590819?

Comment 17

[Gary [:streetwolf52]]

I've gotten the problem with my new profile.

If I middle click on the ad right below the header/logo for the site I can autoscroll even on my production Fx.  

http://www.bbc.co.uk/news/business-11224398

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I can't reproduce this anymore after installing the most recent Windows hourly (cset d510e199203c).

Was hitting it frequently prior to that.

Comment 19

[Gary [:streetwolf52]]

I can't get it to work with a new profile and deleting all my plugins.  At the most it might work one time but that's it.  Could it be OS dependent?  I'm running W7 x64.

Comment 20

[Gary [:streetwolf52]]

(In reply to comment #16)
> Um, any prefs except changing middle click behavior don't affect this behavior.
> 
> Can you reproduce this bug before the fix of bug 590819?

I went back to the 8/30/10 nightly (20100830040705 0487454f4219) and still had the problem.

Comment 21

[Gary [:streetwolf52]]

I re-read the original post.  Following those instructions I do not get the auto scroll icon.  Middle clicking on a link is supposed to open up the link, correct?

Comment 22

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #20)
> (In reply to comment #16)
> > Um, any prefs except changing middle click behavior don't affect this behavior.
> > 
> > Can you reproduce this bug before the fix of bug 590819?
> 
> I went back to the 8/30/10 nightly (20100830040705 0487454f4219) and still had
> the problem.

It's NOT this bug. This is the regression.

(In reply to comment #21)
> I re-read the original post.  Following those instructions I do not get the
> auto scroll icon.  Middle clicking on a link is supposed to open up the link,
> correct?

When you press middle mouse button on text, you should see autoscroll icon. And you release middle mouse button on a link, the link target shouldn't be opened.