Last Comment Bug 593629 - Only perform checks for ARM SIMD and NEON features when the CPU target is ARM
: Only perform checks for ARM SIMD and NEON features when the CPU target is ARM
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: x86 Linux
: -- minor (vote)
: mozilla6
Assigned To: Kyle Huey [:khuey] (khuey@mozilla.com)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-09-04 13:38 PDT by Kyle Huey [:khuey] (khuey@mozilla.com)
Modified: 2011-04-13 20:01 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (1.91 KB, patch)
2010-09-04 13:38 PDT, Kyle Huey [:khuey] (khuey@mozilla.com)
ted: review+
Details | Diff | Review

Description Kyle Huey [:khuey] (khuey@mozilla.com) 2010-09-04 13:38:08 PDT
Created attachment 472193 [details] [diff] [review]
Patch

No sense checking for this when we're building x86.
Comment 1 Ted Mielczarek [:ted.mielczarek] 2010-09-08 10:25:31 PDT
Comment on attachment 472193 [details] [diff] [review]
Patch

># HG changeset patch
># Parent ead88afacadc1ad98fd656886e7a7ee6377b9b73
>diff --git a/configure.in b/configure.in
>--- a/configure.in
>+++ b/configure.in
>@@ -3545,32 +3545,37 @@ AC_SUBST(XEXT_LIBS)
> AC_SUBST(XT_LIBS)
> AC_SUBST(XSS_LIBS)
> 
>-AC_MSG_CHECKING(for ARM SIMD support in compiler)
>-AC_TRY_COMPILE([],
>-               [asm("uqadd8 r1, r1, r2");],
>-               result="yes", result="no")
>-AC_MSG_RESULT("$result")
>-if test "$result" = "yes"; then
>-    AC_DEFINE(HAVE_ARM_SIMD)
>-    HAVE_ARM_SIMD=1
>-fi
>+case "$CPU_ARCH" in
>+arm)

Don't use a case if you only have one value. Just "if test $CPU_ARCH = "arm"; should be fine.
Comment 2 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-04-13 20:01:42 PDT
http://hg.mozilla.org/mozilla-central/rev/8a7dadcb59f5

Note You need to log in before you can comment on or make changes to this bug.