Only perform checks for ARM SIMD and NEON features when the CPU target is ARM

RESOLVED FIXED in mozilla6

Status

()

Core
Build Config
--
minor
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: khuey, Assigned: khuey)

Tracking

unspecified
mozilla6
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 472193 [details] [diff] [review]
Patch

No sense checking for this when we're building x86.
Attachment #472193 - Flags: review?(ted.mielczarek)
Comment on attachment 472193 [details] [diff] [review]
Patch

># HG changeset patch
># Parent ead88afacadc1ad98fd656886e7a7ee6377b9b73
>diff --git a/configure.in b/configure.in
>--- a/configure.in
>+++ b/configure.in
>@@ -3545,32 +3545,37 @@ AC_SUBST(XEXT_LIBS)
> AC_SUBST(XT_LIBS)
> AC_SUBST(XSS_LIBS)
> 
>-AC_MSG_CHECKING(for ARM SIMD support in compiler)
>-AC_TRY_COMPILE([],
>-               [asm("uqadd8 r1, r1, r2");],
>-               result="yes", result="no")
>-AC_MSG_RESULT("$result")
>-if test "$result" = "yes"; then
>-    AC_DEFINE(HAVE_ARM_SIMD)
>-    HAVE_ARM_SIMD=1
>-fi
>+case "$CPU_ARCH" in
>+arm)

Don't use a case if you only have one value. Just "if test $CPU_ARCH = "arm"; should be fine.
Attachment #472193 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/8a7dadcb59f5
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.