593648 - cfx -P/--profiledir option should take relative paths

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Atul Varma [:atul]]

Currently, running 'cfx -P blap' or 'cfx -P ./blap' ought to use a profile in the relative directory, creating one if it doesn't exist. However, instead, Firefox starts up and displays an error dialog titled "Profile Missing" with the text "Your Firefox profile cannot be loaded. It may be missing or inaccessible."

Comment 1

[Atul Varma [:atul]]

Attachment: patch

Comment 2

[Brian Warner [:warner :bwarner]]

Comment on attachment 472221 [details] [diff] [review]
patch

yay for more os.path.abspath() calls. Looks good to me.

Comment 3

[Atul Varma [:atul]]

Thanks! Pushed:

Bug 593648 - cfx -P/--profiledir option should take relative paths
Atul Varma [:atul]
http://hg.mozilla.org/labs/jetpack-sdk/rev/d215a1aaa3a5

Comment 4

[Atul Varma [:atul]]

oh crap. i think the tree is supposed to be frozen.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Yes, the tree is frozen, so checkins for non-blockers need driver approval prior to landing.  In this case, the patch is a low-risk patch that it is reasonable to land during tree freeze, thus a=myk, and you don't need to back it out.  But make sure to ask for approval in advance next time!

Comment 6

[Atul Varma [:atul]]

Thanks myk, I'll definitely remember to do that next time!

Comment 7

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".