Last Comment Bug 593680 - Tab animation perf issues
: Tab animation perf issues
Status: NEW
: meta, perf
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
-- normal with 27 votes (vote)
: ---
Assigned To: Jeff Muizelaar [:jrmuizel]
: 709984 (view as bug list)
Depends on: 599711 627159 633157 648789 663395 684861 750871 753139 774717 783064 786484 tabswitch 790567 tabopen 906827 1015756 649218 708788 713287 720673 724349 australis-tabs-win 750417 783328 783656 998279
Blocks: 596954 771444
  Show dependency treegraph
Reported: 2010-09-05 06:25 PDT by Stéphane Démurget
Modified: 2016-01-12 15:07 PST (History)
40 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Description User image Stéphane Démurget 2010-09-05 06:25:23 PDT
User-Agent:       Mozilla/5.0 (X11; Linux i686; rv:2.0b6pre) Gecko/20100903 Firefox/4.0b6pre
Build Identifier: Mozilla/5.0 (X11; Linux i686; rv:2.0b6pre) Gecko/20100903 Firefox/4.0b6pre

I've hit a performance regression for the opening/closing tab animation.

This seems to be because of the new tab style.

In this build, everything is really smooth:

In the following one, it's not (I only get ~3 frames drawn):

Reproducible: Always

Steps to Reproduce:
1.Get the second build.
Actual Results:  
The new tab style looks great but its animation are sluggish (well, certainly on older hardware).

Expected Results:  
Smooth opening/closing a tab as it was on the first build mentioned.

I've got a Celeron 1.6Ghz computer with the nouveau driver.

Is there any profiling tool I could use to provide more data?
Comment 2 User image Csaba Kozák [:WonderCsabo] 2010-09-25 04:13:11 PDT
I experience it on Win7, too. Especially when other tabs are loading.
Comment 3 User image Nochum Sossonko [:Natch] 2010-10-28 13:29:44 PDT
I experience some of this sluggishness although only with D3D, DirectWrite and D2D enabled (which is by default for my hardware). Perhaps there is another bug for that somewhere?
Comment 4 User image (mostly gone) XtC4UaLL [:xtc4uall] 2010-12-28 14:49:25 PST
Bug 575056 & Bug 572488 added Opaqueness combined with -moz-linear-gradient Usage.
So isn't this rather a Core Perf Bug?
Comment 5 User image Patrick Walton (:pcwalton) 2011-01-02 20:53:36 PST
Nominating for blocking; I'm seeing this too, and this really hurts the perception of Firefox 4 IMO, since one of the first things users will do will be to open a new tab and watch the animation. If it's chunky, that's a bad first impression.
Comment 6 User image Mike Beltzner [:beltzner, not reading bugmail] 2011-01-03 20:45:12 PST
Does it only happen when hardware acceleration is enabled? I'm not seeing it on my Win 7 machine, but I don't have HW accel enabled.

Speculatively moving to GFX based on comment 4, but if we could get some details on graphics H/W where we're seeing this and whether or not turning accel on or off (in Prefs > Advanced) that would help us confirm!
Comment 7 User image Patrick Walton (:pcwalton) 2011-01-04 22:10:07 PST
Using my framerate monitor addon I hacked together today [1], on my Linux netbook (Samsung NC10, two years old) I'm getting new tab animation framerates between 10 and 35 fps on a clean profile. On my work high-end MacBook Pro I'm getting 40-55 fps.

This doesn't seem fast enough to me. IMO we should be at 60 fps on high end machines, and at *least* 30 on the low end.

I profiled the new tab animation on Mac and it seems that we spend a lot of time in the blur code. I suspect we have too many shadows in the tab bar.

Comment 8 User image Patrick Walton (:pcwalton) 2011-01-04 22:13:38 PST
Just tried again: when switching back to Firefox after using something else in the foreground, on the same Linux netbook I get around 5-10 FPS for the new tab animation.
Comment 9 User image Mike Beltzner [:beltzner, not reading bugmail] 2011-01-05 20:52:19 PST
Did we not at some point have a bug about detecting when the animation was taking too long and just skipping it? Perhaps I was dreaming.

cc'ing Shorlander and Dao to see if they believe there's a quick fix for the "too many shadows" assertion of comment 7.
Comment 10 User image Dão Gottwald [:dao] 2011-01-06 01:52:58 PST
We don't use box-shadow for tabs on any platform, so it would be interesting to know what exactly is being redrawn there.
Comment 11 User image Dietrich Ayala (:dietrich) 2011-01-12 02:30:55 PST
Performance regression in primary UI responsiveness -> blocking+.
Comment 12 User image Dão Gottwald [:dao] 2011-01-12 06:32:05 PST
This bug is a mess. It was filed as a Linux theme regression (which I can't reproduce, maybe because I don't get accelerated layers on my netbook) and then changed to all platforms and Core:Graphics because people saw bad performance on Windows with hardware acceleration. Then Patrick profiled something on OS X and Joe moved the bug back to Firefox:Theme. Now it's blocking as a regression, which is fine theoretically, except that I have no idea what regression we're tracking.
Comment 13 User image Dietrich Ayala (:dietrich) 2011-01-12 06:45:41 PST
This bug should be about the original report. If there are actually different causes for each OS, then there should be separate bugs for those to clarify what needs to be done in those other cases.
Comment 14 User image Mike Beltzner [:beltzner, not reading bugmail] 2011-01-12 07:49:06 PST
Is it all Linux machines, or only older ones? If all Linux, please remove [softblocker] so we can reconsider that verdict.
Comment 15 User image Dietrich Ayala (:dietrich) 2011-01-27 08:24:16 PST
Measuring with framerate-monitor, I'm getting 30fps routinely. However, I see real lag when opening a tab on a daily basis. Could be add-ons though :(
Comment 16 User image Dietrich Ayala (:dietrich) 2011-01-28 07:36:48 PST
(In reply to comment #7)
> I profiled the new tab animation on Mac and it seems that we spend a lot of
> time in the blur code. I suspect we have too many shadows in the tab bar.

Dao, Shorlander: where would one disable all related styling to test this theory out?
Comment 17 User image Dão Gottwald [:dao] 2011-01-28 07:45:17 PST
(In reply to comment #16)
> (In reply to comment #7)
> > I profiled the new tab animation on Mac and it seems that we spend a lot of
> > time in the blur code. I suspect we have too many shadows in the tab bar.
> Dao, Shorlander: where would one disable all related styling to test this
> theory out?

We don't use shadows in the tab bar, see comment 10. Also, this bug is about Linux.
Comment 18 User image Mike Beltzner [:beltzner, not reading bugmail] 2011-03-03 07:21:18 PST

This bug is one of 7 automatically changed from blocking2.0:final+ to blocking2.0:.x during the endgame of Firefox 4 for the following reasons:

 - it was marked as a soft blocking issue without a requirement for beta coverage
Comment 19 User image Marco Castelluccio [:marco] 2011-11-30 09:57:55 PST
This is an issue also under Windows.
Comment 20 User image (dormant account) 2011-12-01 12:36:53 PST
Jeff, can you triage this? Ie if this something we can fix by tweaking css, should it be a P1?
Comment 21 User image Dão Gottwald [:dao] 2011-12-12 14:23:25 PST
(In reply to Marco Castelluccio from comment #19)
> This is an issue also under Windows.

Ok. I'll now give up trying to keep this bug focused on the regression allegedly caused by bug 572488.
Comment 22 User image Girish Sharma [:Optimizer] 2012-01-24 05:10:48 PST
From the last 10 to 12 days, in the latest Nightly, just after clicking on the close button or hitting the middle mouse button on a tab to close it, the close button of the tab quickly shifts to the left of the closing tab, thus now making two close buttons close to each other, the Title text of the tab disappears ans the tab's width starts decreasing. But then the close button creates a jerk as when the tab's width reaches that of the close button, the close button disappears.It would have been a lot smoother if the close button were to disappear along with the title text and the closing animation would continue smoothly.I am on Windows 7 , latest Nightly 32 bit and HWA enabled.Didn't know where to bring up this topic so just commenting here.
Comment 23 User image Dão Gottwald [:dao] 2012-01-24 05:13:55 PST
(In reply to scrapmachines from comment #22)
Please file a new bug.
Comment 24 User image Marco Castelluccio [:marco] 2012-09-19 02:23:46 PDT
Also, dlbi (bug 539356) will likely improve the tab animations.
Comment 25 User image Dão Gottwald [:dao] 2012-10-31 09:35:23 PDT
*** Bug 709984 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.