Closed
Bug 593690
Opened 14 years ago
Closed 14 years ago
Tabview button and other toolbarbuttons increase the tab bar height
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 4.0b7
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.35 KB,
patch
|
ventnor.bugzilla
:
review+
|
Details | Diff | Splinter Review |
Attachment #472271 -
Flags: review?(gavin.sharp)
|
Assignee | |
Updated•14 years ago
|
|
|
Assignee | |
Updated•14 years ago
|
|
||
Comment 2•14 years ago
|
||
Dāo, does the Panorama button still do this with the latest version of bug 589010?
|
|
Assignee | |
Comment 3•14 years ago
|
||
(In reply to comment #2)
> Dāo, does the Panorama button still do this with the latest version of bug
> 589010?
Yes.
|
||
Comment 4•14 years ago
|
||
Fixing this will most likely also fix bug #594013, because currently the app tabs look fine as long as there is no action button added to the tab bar (like tab candy etc)
This goes even further as explained in bug #594922 which has a lot of dupe information but issue a is still valid after this patch I think. Maybe also the persona issue.
|
|
Assignee | |
Comment 5•14 years ago
|
||
updated to tip
Attachment #472271 -
Attachment is obsolete: true
Attachment #474356 -
Flags: review?(gavin.sharp)
Attachment #472271 -
Flags: review?(gavin.sharp)
|
|
Assignee | |
Updated•14 years ago
|
Attachment #474356 -
Flags: review?(ventnor.bugzilla)
|
||
Updated•14 years ago
|
Attachment #474356 -
Flags: review?(ventnor.bugzilla) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #474356 -
Flags: review?(gavin.sharp) → approval2.0?
|
|
||
Comment 6•14 years ago
|
||
Tested the patch, does what it says and also fixes bug #594013. I will update #594922 accordingly.
|
|
Assignee | |
Comment 7•14 years ago
|
||
Blocks: 593967
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6
|
|
Assignee | |
Updated•14 years ago
|
Attachment #474356 -
Flags: approval2.0?
You need to log in
before you can comment on or make changes to this bug.
Description
•