Closed Bug 593747 Opened 11 years ago Closed 11 years ago

TM: 64-bit VC9: dist\include\jsval.h(636) : error C2143: syntax error : missing ';' before 'type'

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86_64
Windows Vista
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: m_kato, Assigned: m_kato)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

fix
1.28 KB, patch
luke
: review+
Details | Diff | Splinter Review 
This is tracemonkey tree.

jsval.h is included from C source files such as jsdebug.c in js/jsd.  So variable define should be before assertion code.


c:/mozilla-build/python25/python2.5.exe -O c:/Workspace/hg.mozilla.org/tracemonkey/build/cl.py cl -Fojsdebug.obj -c -DXPCOM_TRANSLATE_NSGM_ENTRY_POINT=1 -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DSTATIC_EXPORTABLE_JS_API -DZLIB_INTERNAL -DOSTYPE=\"WINNT6.0\" -DOSARCH=WINNT -DEXPORT_JSD_API  -I/c/Workspace/hg.mozilla.org/tracemonkey/js/jsd -I. -I../../dist/include -I../../dist/include/nsprpub  -Ic:/Workspace/hg.mozilla.org/objdir-tm-win64/dist/include/nspr -Ic:/Workspace/hg.mozilla.org/objdir-tm-win64/dist/include/nss         -TC -nologo -W3 -Gy -Fdgenerated.pdb  -DNDEBUG -DTRIMMED -Zi -Zi -UDEBUG -DNDEBUG -GL -O1 -MD            -FI ../../dist/include/mozilla-config.h -DMOZILLA_CLIENT /c/Workspace/hg.mozilla.org/tracemonkey/js/jsd/jsdebug.c
jsdebug.c
c:\workspace\hg.mozilla.org\objdir-tm-win64\dist\include\jsval.h(636) : error C2143: syntax error : missing ';' before 'type'
c:\workspace\hg.mozilla.org\objdir-tm-win64\dist\include\jsval.h(638) : error C2065: 'ptrBits' : undeclared identifier
c:\workspace\hg.mozilla.org\objdir-tm-win64\dist\include\jsval.h(674) : error C2143: syntax error : missing ';' before 'type'
c:\workspace\hg.mozilla.org\objdir-tm-win64\dist\include\jsval.h(676) : error C2065: 'objBits' : undeclared identifier
c:\workspace\hg.mozilla.org\objdir-tm-win64\dist\include\jsval.h(681) : error C2061: syntax error : identifier 'JSVAL_IS_NULL_IMPL'
c:\workspace\hg.mozilla.org\objdir-tm-win64\dist\include\jsval.h(681) : error C2059: syntax error : ';'
c:\workspace\hg.mozilla.org\objdir-tm-win64\dist\include\jsval.h(681) : error C2059: syntax error : 'type'
c:\workspace\hg.mozilla.org\objdir-tm-win64\dist\include\jsval.h(703) : warning C4013: 'JSVAL_IS_NULL_IMPL' undefined; assuming extern returning int
Attached patch fix — — Splinter Review
Assignee: general → m_kato
Attachment #472327 - Flags: review?(lw)
Attachment #472327 - Flags: review?(lw) → review+
http://hg.mozilla.org/tracemonkey/rev/a4da54094b4c
Whiteboard: fixed-in-tracemonkey
already merged into m-c
http://hg.mozilla.org/mozilla-central/rev/a4da54094b4c
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.