Closed Bug 593758 Opened 14 years ago Closed 14 years ago

List are not formatted anymore during html to text conversion

Categories

(Core :: DOM: Serializers, defect)

Product:
Core
Component:
DOM: Serializers
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b7
Tracking Flags:
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: laurent, Assigned: ehsan.akhgari)

References

Details

(Keywords: regression)

Attachments

(2 files)

Patch (v1)
5.84 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
Part 2: tests
7.95 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
Since the bug 365805 has been fixed, when a html mail is converting to text, list are not formated any more.

The code removed in bug 365805 should be backed out and a test should be added to generate formatted list, depending of document encoder flags. (see my comment https://bugzilla.mozilla.org/show_bug.cgi?id=365805#c26 )
Yeah, we need to fix this.
Blocks: 365805
blocking2.0: --- → ?
No longer depends on: 365805
Ehsan, can you look into this regression?
Assignee: nobody → ehsan
blocking2.0: ? → betaN+
(In reply to comment #2)
> Ehsan, can you look into this regression?

Sure!
Attached patch Patch (v1) — — Splinter Review 

        Attachment #479204 -
        Flags: review?(jst)

    
  
Whiteboard: [has patch][needs review jst]

    
    

    
  
Comment on attachment 479204 [details] [diff] [review]
Patch (v1)

Boris, is this something which you can review?

        Attachment #479204 -
        Flags: review?(jst) → review?(bzbarsky)

    
  
Whiteboard: [has patch][needs review jst] → [has patch][needs review bz]

    
    

    
  
Comment on attachment 479204 [details] [diff] [review]
Patch (v1)

Yeah.

> +           (type == eHTMLTag_dt)) &&

Fix the indentation of that line?  Should be indented one more space.

r=me, though would be nice to have some tests here.

        Attachment #479204 -
        Flags: review?(bzbarsky) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Part 2: tests
        — 
          — Splinter Review
      

    


  
This patch actually enables TestOutSinks.pl tests to be run as part of |make check|, and adds a test for the changes in this bug.

        Attachment #482729 -
        Flags: review?(bzbarsky)

    
    

    
  
Comment on attachment 482729 [details] [diff] [review]
Part 2: tests

r=me

        Attachment #482729 -
        Flags: review?(bzbarsky) → review+

    
  
Whiteboard: [has patch][needs review bz] → [needs landing]

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/7a903a40b897
http://hg.mozilla.org/mozilla-central/rev/bc5c8ff46d06
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla2.0b8
Summary: List are not formated anymore during html to text conversion → List are not formatted anymore during html to text conversion
Target Milestone: mozilla2.0b8 → mozilla2.0b7

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: