User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:188.8.131.52) Gecko/20100723 Ubuntu/10.04 (lucid) Firefox/3.6.8
On my Ubuntu 10.04, Trunk (f203095c85de) build fails when you have the following line in your mozconfig file:
c++ -o nsDependentString.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /home/halton/work/projects/mozilla/mozilla-central/config/gcc_hidden.h -DMOZILLA_INTERNAL_API -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux -D_IMPL_NS_COM -I/home/halton/work/projects/mozilla/mozilla-central/xpcom/string/src -I. -I../../../dist/include -I../../../dist/include/nsprpub -I/home/halton/work/projects/mozilla/qtdebug/dist/include/nspr -I/home/halton/work/projects/mozilla/qtdebug/dist/include/nss -fPIC -frtti -fexceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -pedantic -Wno-long-long -fno-strict-aliasing -fshort-wchar -pthread -pipe -DDEBUG -D_DEBUG -DTRACING -g -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MF .deps/nsDependentString.pp /home/halton/work/projects/mozilla/mozilla-central/xpcom/string/src/nsDependentString.cpp
In file included from ../../../dist/include/mozilla/mozalloc.h:51,
../../../dist/stl_wrappers/new:45:4: error: #error "STL code can only be used with -fno-exceptions"
make: *** [nsDependentString.o] Error 1
make: Leaving directory `/home/halton/work/projects/mozilla/qtdebug/xpcom/string/src'
My configure script is
Adding configure options from /home/halton/work/projects/mozilla/mozilla-central/mozconfig:
Benjamin, is this even a supported build option nowadays? I would think that if it is the #error should be compiled out when this option is used.
I don't think we have any plans to actually make Mozilla work with C++ exceptions anytime soon, so we should just remove this broken option.
We should remove the RTTI option while we're at it.
Created attachment 473380 [details] [diff] [review]
This patch removes the --enable-cpp-exceptions and --enable-cpp-rtti configure options.
Wait. The rtti option comes in handy every time we need to figure out which timer callbacks are keeping our threads awake, like in bug 565217.
Please keep the RTTI option.
Comment on attachment 473380 [details] [diff] [review]
r- per bsmedberg. I didn't know that cpp-rtti was still useful.
Created attachment 473542 [details] [diff] [review]
This removes --enable-cpp-exceptions.
Created attachment 473564 [details] [diff] [review]
Sorry, that last patch was incomplete. I left out the mozalloc.h changes.
Let's wait until after branch, just to keep the tree clear for more important stuff.
Just came across this bug and I think we are now far enough after the branch ;)
Created attachment 566499 [details] [diff] [review]
Patch v1.2 rebased
As last patch but updated to tip. Couple of hunks less now, since the Irix sections in configure have been removed by bug 680792.
Comment on attachment 566499 [details] [diff] [review]
Patch v1.2 rebased
Ted, this has received r+ a year ago, but just wanted to:
- Confirm this is still wanted
- Ask what you wanted done about the |AC_DEFINE(CPP_THROW_NEW, [throw()])| (here: https://bugzilla.mozilla.org/attachment.cgi?id=566499&action=diff#a/configure.in_sec5), now that http://hg.mozilla.org/mozilla-central/diff/78af9261582f/configure.in#l1.100 has landed since.
Builds fine locally using MSVC2010, but will obviously send to try too before pushing.
Taking bug, just so this shows up on my searches. Mitch, hope that's ok :-) If you'd rather take over, that's fine. Patch author will be left as you obviously either way.
Created attachment 568663 [details] [diff] [review]
Updated to tip + mozalloc.h changes omitted since they've landed in bug 695171 since.