Closed
Bug 593768
Opened 14 years ago
Closed 13 years ago
Remove --enable-cpp-exceptions configure option
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla10
People
(Reporter: halton.huo, Assigned: emorley)
References
Details
Attachments
(1 file, 4 obsolete files)
12.23 KB,
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.8) Gecko/20100723 Ubuntu/10.04 (lucid) Firefox/3.6.8 Build Identifier: On my Ubuntu 10.04, Trunk (f203095c85de) build fails when you have the following line in your mozconfig file: ac_add_options --enable-cpp-exceptions c++ -o nsDependentString.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /home/halton/work/projects/mozilla/mozilla-central/config/gcc_hidden.h -DMOZILLA_INTERNAL_API -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux -D_IMPL_NS_COM -I/home/halton/work/projects/mozilla/mozilla-central/xpcom/string/src -I. -I../../../dist/include -I../../../dist/include/nsprpub -I/home/halton/work/projects/mozilla/qtdebug/dist/include/nspr -I/home/halton/work/projects/mozilla/qtdebug/dist/include/nss -fPIC -frtti -fexceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -pedantic -Wno-long-long -fno-strict-aliasing -fshort-wchar -pthread -pipe -DDEBUG -D_DEBUG -DTRACING -g -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MF .deps/nsDependentString.pp /home/halton/work/projects/mozilla/mozilla-central/xpcom/string/src/nsDependentString.cpp In file included from ../../../dist/include/mozilla/mozalloc.h:51, from ../../../dist/include/nscore.h:50, from ../../../dist/include/nsStringFwd.h:45, from ../../../dist/include/nsAString.h:43, from ../../../dist/include/nsSubstring.h:40, from ../../../dist/include/nsString.h:44, from ../../../dist/include/nsDependentString.h:43, from /home/halton/work/projects/mozilla/mozilla-central/xpcom/string/src/nsDependentString.cpp:40: ../../../dist/stl_wrappers/new:45:4: error: #error "STL code can only be used with -fno-exceptions" make[1]: *** [nsDependentString.o] Error 1 make[1]: Leaving directory `/home/halton/work/projects/mozilla/qtdebug/xpcom/string/src' My configure script is Adding configure options from /home/halton/work/projects/mozilla/mozilla-central/mozconfig: --prefix=/usr --libdir=/usr/lib --with-system-jpeg --with-system-zlib --enable-debug --disable-optimize --enable-logging --disable-tests --disable-installer --disable-crashreporter --disable-javaxpcom --enable-printing --disable-embedding-tests --disable-elf-dynstr-gc --disable-updater --enable-meego --enable-meegotouch --enable-application=mobile --disable-necko-wifi --disable-accessibility --disable-thumb2 --enable-gstreamer --enable-cpp-rtti --enable-cpp-exceptions --enable-default-toolkit=cairo-qt Reproducible: Always
Comment 1•14 years ago
|
||
Benjamin, is this even a supported build option nowadays? I would think that if it is the #error should be compiled out when this option is used.
Comment 2•14 years ago
|
||
I don't think we have any plans to actually make Mozilla work with C++ exceptions anytime soon, so we should just remove this broken option.
Status: UNCONFIRMED → NEW
Component: XPCOM → Build Config
Ever confirmed: true
QA Contact: xpcom → build-config
Summary: Trunk builds fail when using --enable-cpp-exceptions → Remove --enable-cpp-exceptions configure option
Comment 3•14 years ago
|
||
We should remove the RTTI option while we're at it.
Summary: Remove --enable-cpp-exceptions configure option → Remove --enable-cpp-exceptions and --enable-cpp-rtti configure options
Comment 4•14 years ago
|
||
This patch removes the --enable-cpp-exceptions and --enable-cpp-rtti configure options.
Assignee: nobody → mitchell.field
Status: NEW → ASSIGNED
Attachment #473380 -
Flags: review?(ted.mielczarek)
Updated•14 years ago
|
OS: Linux → All
Hardware: x86 → All
Wait. The rtti option comes in handy every time we need to figure out which timer callbacks are keeping our threads awake, like in bug 565217.
Comment 6•14 years ago
|
||
Please keep the RTTI option.
Comment 7•14 years ago
|
||
Comment on attachment 473380 [details] [diff] [review] Patch v1.0 r- per bsmedberg. I didn't know that cpp-rtti was still useful.
Attachment #473380 -
Flags: review?(ted.mielczarek) → review-
Comment 8•14 years ago
|
||
This removes --enable-cpp-exceptions.
Attachment #473380 -
Attachment is obsolete: true
Attachment #473542 -
Flags: review?(ted.mielczarek)
Updated•14 years ago
|
Summary: Remove --enable-cpp-exceptions and --enable-cpp-rtti configure options → Remove --enable-cpp-exceptions configure option
Updated•14 years ago
|
Attachment #473542 -
Flags: review?(ted.mielczarek) → review+
Comment 9•14 years ago
|
||
Sorry, that last patch was incomplete. I left out the mozalloc.h changes.
Attachment #473542 -
Attachment is obsolete: true
Attachment #473564 -
Flags: review?(ted.mielczarek)
Updated•14 years ago
|
Attachment #473564 -
Flags: review?(ted.mielczarek) → review+
Updated•14 years ago
|
Attachment #473564 -
Flags: approval2.0?
Comment 10•14 years ago
|
||
Let's wait until after branch, just to keep the tree clear for more important stuff.
Attachment #473564 -
Flags: approval2.0? → approval2.0-
Comment 11•13 years ago
|
||
Just came across this bug and I think we are now far enough after the branch ;)
Assignee | ||
Comment 12•13 years ago
|
||
As last patch but updated to tip. Couple of hunks less now, since the Irix sections in configure have been removed by bug 680792.
Attachment #473564 -
Attachment is obsolete: true
Assignee | ||
Comment 13•13 years ago
|
||
Comment on attachment 566499 [details] [diff] [review] Patch v1.2 rebased Ted, this has received r+ a year ago, but just wanted to: - Confirm this is still wanted - Ask what you wanted done about the |AC_DEFINE(CPP_THROW_NEW, [throw()])| (here: https://bugzilla.mozilla.org/attachment.cgi?id=566499&action=diff#a/configure.in_sec5), now that http://hg.mozilla.org/mozilla-central/diff/78af9261582f/configure.in#l1.100 has landed since. Builds fine locally using MSVC2010, but will obviously send to try too before pushing.
Attachment #566499 -
Flags: review?(ted.mielczarek)
Assignee | ||
Comment 14•13 years ago
|
||
Taking bug, just so this shows up on my searches. Mitch, hope that's ok :-) If you'd rather take over, that's fine. Patch author will be left as you obviously either way.
Assignee: mitchell.field → bmo
Flags: in-testsuite-
Updated•13 years ago
|
Attachment #566499 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 15•13 years ago
|
||
Updated to tip + mozalloc.h changes omitted since they've landed in bug 695171 since.
Attachment #566499 -
Attachment is obsolete: true
Assignee | ||
Comment 16•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/838ec216947e
Target Milestone: --- → mozilla10
Version: unspecified → Trunk
Assignee | ||
Comment 17•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/838ec216947e
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•