593813 - Ligatures don't display at all if dx/dy is used on text

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

Ligatures don't display at all if dx/dy is used on text.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: testcase

Comment 2

[Jonathan Watt [:jwatt]]

For me this testcase displays "oat", whereas it should display "float".

Comment 3

[Jonathan Watt [:jwatt]]

The testcase works fine in 3.6.8.

Comment 4

[Robert Longson [:longsonr]]

In nsSVGGlyphFrame there is this test...

  if (xListCount <= 1 &&
      yListCount <= 1 &&
      dxList.Length() == 0 &&
      dyList.Length() == 0 &&
...

dxList.Length() <= 1 and dyList.Length() <= 1 is more appropriate. Any patch would bitrot bug 333698 though and would only work for a single dx (or dy value).

Really we should disable ligatures if the text layout positions characters but that doesn't work on Windows (or Linux either I think).

Comment 5

[Robert Longson [:longsonr]]

Single dx, dy now work after check in for bug 333698. We have existing bugs on ligatures e.g. bug 468035

Comment 6

[Robert Longson [:longsonr]]

Testcase fixed by bug 333698. Any existing ligature issues would be covered by bug 563430