Last Comment Bug 593838 - unsortedBookmarks.png ought to have equal amount of transparency at top/bottom
: unsortedBookmarks.png ought to have equal amount of transparency at top/bottom
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Themes (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: seamonkey2.1b1
Assigned To: Stefan [:stefanh] (away until December 6)
:
:
Mentors:
Depends on:
Blocks: 593840
  Show dependency treegraph
 
Reported: 2010-09-06 10:27 PDT by Stefan [:stefanh] (away until December 6)
Modified: 2010-09-07 04:04 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Adjust icon (2.38 KB, patch)
2010-09-06 10:30 PDT, Stefan [:stefanh] (away until December 6)
neil: review+
neil: superreview+
Details | Diff | Splinter Review

Description Stefan [:stefanh] (away until December 6) 2010-09-06 10:27:30 PDT
While working on bug 586026, I noticed that the unsortedBookmarks.png icon is not vertically centered - it has all its transparency at the top. I think it will look a lot better with equal amounts of transparency at top/bottom - especially in the file bookmark menulist.
Comment 1 Stefan [:stefanh] (away until December 6) 2010-09-06 10:30:48 PDT
Created attachment 472426 [details] [diff] [review]
Adjust icon

Hmm, I will file a separate bug for removing some data chunks from all our icons
Comment 2 Robert Kaiser 2010-09-06 12:38:08 PDT
Comment on attachment 472426 [details] [diff] [review]
Adjust icon

I'll leave that to Neil - I thought it was reasonable to have the bucket the bookmarks land in sit at the bottom border, but if centering the image vertically looks better for you guys, let's do it.
Comment 3 Stefan [:stefanh] (away until December 6) 2010-09-06 14:22:35 PDT
It looks a bit bad on mac, if you think it's fine on win/nix I can fork the icon - but I checked some other win/nix icons (that appear in the menulist) and they seem to have  transparency at the bottom.
Comment 4 Stefan [:stefanh] (away until December 6) 2010-09-07 04:04:03 PDT
http://hg.mozilla.org/comm-central/rev/7fbe67b91630

Note You need to log in before you can comment on or make changes to this bug.