593860 - [D2D] Black box appearing when D3D9 enabled

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Oskar Ivanić (:icecold)]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b6pre) Gecko/20100906 Firefox/4.0b6pre
Build Identifier: 

D3D9 is enabled by default on my system.
When I use Facebook chat or when I surf on some websites area becomes black.
Mostly happens on Facebook.

Reproducible: Always

Steps to Reproduce:
1.Go to Facebook and login.
2.Open chat windows to see online friends.
3.Click on any friend to open chat windows and then black box will appear.
Actual Results:  
Black box was next to chat window.


OS: Windows 7
GPU: Nvidia 8400GS using 258.96 drivers.

Comment 1

[Oskar Ivanić (:icecold)]

Attachment: Black box in chat

Comment 2

[Thomas Seguin]

Could this bug be related to: https://bugzilla.mozilla.org/show_bug.cgi?id=593219 ?

Comment 3

[jorge alves]

This happens a lot using firebug's inspect tool on any page.
(firebug 1.7X.0a1)

Comment 4

[Myzar]

(In reply to comment #2)
> Could this bug be related to:
> https://bugzilla.mozilla.org/show_bug.cgi?id=593219 ?

no this happens without applying a persona and it's very easy to reproduce just log in facebook and open the chat, it only happens with D3D9 enabled

Comment 5

[Myzar]

This is a screenshot that the reporter forgot to include 

http://img268.imageshack.us/i/issuef.jpg/

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

A reduced HTML testcase would really help

Comment 7

[jorge alves]

Attachment: reduced testcase

Seems to reproduce on my end (hopefully everywhere).

Tried out some things (interactivity, scrolling, multiple examples) but the effect was a bit erratic.

Goes away if I take the background-color off.

Comment 8

[Bas Schouten (:bas.schouten)]

I can reproduce this both with D2D and D3D. I'm assuming this is about the small black rectangular areas at the sides of the DIVs.

Comment 9

[Csaba Kozák [:WonderCsabo]]

Comment on attachment 472516 [details]
reduced testcase

Interesting. In the attachment edit window, the testcase is displayed well. If i simply open the attachemnt, there arem some black areas. (w/ D2D and layers ON)

Comment 10

[Bas Schouten (:bas.schouten)]

Attachment: Draw only VisibleRegion

This causes us to draw only the visible region for our ThebesLayers.

Comment 11

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 472759 [details] [diff] [review]
Draw only VisibleRegion

>   outp.vPosition = mul(mProjection, outp.vPosition);
>   
>-  outp.vTexCoords = aVertex.vPosition.xy;
>+  outp.vTexCoords.x = vTextureCoords.x + aVertex.vPosition.x * vTextureCoords.z;
>+  outp.vTexCoords.y = vTextureCoords.y + aVertex.vPosition.y * vTextureCoords.w;

This would be cleaner if texture coords were vertex attributes instead of implicitly selecting texture coordinates using multiplication by 0 or 1.
I know you prefer these tricks, but I'm not sure the performance gain is worth it. If you can show a measurable difference I'd be more easily convinced.

Comment 12

[Bas Schouten (:bas.schouten)]

Attachment: Draw only VisibleRegion v2

Adjusted to make our creating a rectangle through the shaders approach better documented. If you agree with this approach Jeff, I'll move our Quad stuff to use the same helpers and approach.

I've also reduced validation to draw only the visible region, we no longer need to draw the bounds.

Comment 13

[Bas Schouten (:bas.schouten)]

Attachment: Draw only VisibleRegion v3

Comment 14

[Bas Schouten (:bas.schouten)]

Attachment: Draw only VisibleRegion v4

Comment 15

[Bas Schouten (:bas.schouten)]

Attachment: Draw only VisibleRegion v4

Comment 16

[Bas Schouten (:bas.schouten)]

http://hg.mozilla.org/mozilla-central/rev/c1bb86ae655a

Comment 17

[Myzar]

Using http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/1283919660/ which is supposed to have this fix , the bug is only fixed for the test case but not for the facebook chat. I still have the black box like in the screenshot attached to this bug

Comment 18

[Csaba Kozák [:WonderCsabo]]

Same for me. If i hit Ctrl+T, the black box disappears.

Comment 20

[jorge alves]

I'm not in the same PC right now, but it seems to have solved it for me.

Comment 21

[Oskar Ivanić (:icecold)]

I can also confirm that issue on provided screenshot is not fixed. It's still happening. Just do the STR.

Comment 22

[Bas Schouten (:bas.schouten)]

(In reply to comment #21)
> I can also confirm that issue on provided screenshot is not fixed. It's still
> happening. Just do the STR.

Considering I don't have a facebook account, that's going to be tricky :). I indeed fixed the testcase. Turns out the testcase is another bug I suppose :-). Can anyone point me at any other, public, site which has this bug.

Comment 23

[Oskar Ivanić (:icecold)]

(In reply to comment #22)
> Considering I don't have a facebook account, that's going to be tricky :). I
> indeed fixed the testcase. Turns out the testcase is another bug I suppose :-).
> Can anyone point me at any other, public, site which has this bug.

Sadly but I haven't found a site that has this bug. I actually did, but on that site it happened randomly with no STR and sometimes it could take 15 minutes. So staring at text you don't understand and waiting is worse than making a Facebook profile :D Or if someone has a site with this bug. Btw. you can make fake profile :D

Comment 24

[Thomas Seguin]

I think I've found one. You should try going to this site: http://www.clubic.com/moteur-de-recherche/actualite-363754-google-instant-recherche-instantanee.html and click on a picture.

Comment 25

[jorge alves]

Attachment: another reduced testcase

To reproduce the issue click "toggle second TD" twice..

I added "toggle first TD" to the testcase because it seemed to me that its behavior was quirky (another bug?). Also, if the first TD is hidden the original issue doesn't reproduce.

Comment 26

[jorge alves]

(In reply to comment #24)
At first glance it doesn't look like it's the same issue, at least not the one on my second try. :)

Comment 27

[Bas Schouten (:bas.schouten)]

Confirmed, I can reproduce issues with the new test case.

Comment 28

[Bas Schouten (:bas.schouten)]

Only occurs with D2D.

Comment 29

[jorge alves]

I also looked into the issue reported by Thomas in #24 but not believing it's the same thing I avoided attaching a testcase and instead uploaded it here:

http://www.mediafire.com/?2q36m9nyuf63buy
(sorry, couldn't think of anywhere else to put it)

Clicking twice makes the transparent div appear dark and selecting the text inside it creates a nice gradient effect. :)
Apparently it's trying to blend with black instead of the background color (white).

Comment 30

[Bas Schouten (:bas.schouten)]

The latest test case is caused by by bug 594624. There's a patch on that bug.

Comment 31

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This is bug 594624 now.

We should have a reftest here, by the way.

Comment 32

[Bas Schouten (:bas.schouten)]

Let's hope this is finally fixed with the fixing of bug 594624!

Comment 33

[Myzar]

confirming fixed

Comment 34

[Bas Schouten (:bas.schouten)]

Excellent! Thanks.

Comment 35

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We really do need a reftest for this.