Catch exception when list of users is empty

RESOLVED FIXED

Status

Release Engineering
General Automation
P5
normal
RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: armenzg, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [buildbot])

(Reporter)

Description

7 years ago
In the output at the bottom of the comment we see this:
2010-09-06 11:37:41-0700 [Broker,1404,10.2.91.158] sending mail (735 bytes) to []
which shows that we are trying to send emails to an empty list of users.

I don't know why the list is empty and not sure if we want to let the exception happen to catch it in our twistd.log exception emails.

I believe this is the push that triggered the build:
http://hg.mozilla.org/try/pushloghtml?changeset=5f2262bdbd54

Involved code:
================
http://mxr.mozilla.org/build/source/buildbot/master/buildbot/status/mail.py#496

Involved output:
================
2010-09-06 11:37:40-0700 [Broker,1404,10.2.91.158] Starting factory <twisted.mail.smtp.SMTPSenderFactory instance at 0xc24a1ec>
2010-09-06 11:37:41-0700 [Broker,1404,10.2.91.158] INVALID EMAIL: %rhg
2010-09-06 11:37:41-0700 [Broker,1404,10.2.91.158] sending mail (735 bytes) to []
2010-09-06 11:37:41-0700 [Broker,1404,10.2.91.158] Starting factory <twisted.mail.smtp.SMTPSenderFactory instance at 0xcc6ef0c>
2010-09-06 11:37:41-0700 [Broker,1404,10.2.91.158] BuildSlave.detached(try-w32-slave32)
2010-09-06 11:37:41-0700 [-] releaseLocks(<Build WINNT 5.2 tryserver build>): []
2010-09-06 11:37:41-0700 [Broker,1404,10.2.91.158] Log output: Running post_upload.py -b tryserver -p firefox -i 20100906083233 --revision 5f2262bdbd54 --who hg --builddir tryserver-win32 --release-to-tryserver-builds /tmp/tmp.uhGSd29988 /tmp/tmp.uhGSd29988/tryserver-win32-build2707.txt.gz
        http://stage.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/hg-5f2262bdbd54/tryserver-win32/tryserver-win32-build2707.txt.gz

2010-09-06 11:37:41-0700 [SMTPSender,client] Unhandled error in Deferred:
2010-09-06 11:37:41-0700 [SMTPSender,client] Unhandled Error
        Traceback (most recent call last):
        Failure: twisted.mail.smtp.SMTPDeliveryError: No recipients accepted
        >>> MAIL FROM:<tryserver@build.mozilla.org>
        <<< 250 2.1.0 Ok
Strange that it thinks the who is 'hg'. This is the relevant part of json-pushes:
 "16716": {
  "date": 1283777642, 
  "changesets": [
   "5f2262bdbd548d45e5945bd4933ea60a8b7dccbd"
  ], 
  "user": "Pidgeot18@gmail.com"
 }, 
Looks consistent with other pushes. Something busted in the poller ?
(In reply to comment #1)
> Strange that it thinks the who is 'hg'. This is the relevant part of
> json-pushes:
>  "16716": {
>   "date": 1283777642, 
>   "changesets": [
>    "5f2262bdbd548d45e5945bd4933ea60a8b7dccbd"
>   ], 
>   "user": "Pidgeot18@gmail.com"
>  }, 
> Looks consistent with other pushes. Something busted in the poller ?

It's been this way prior to the hg poller change.  I suspect something to do with the MercurialLookup code.
Priority: -- → P5

Updated

6 years ago
Component: Release Engineering → Release Engineering: Automation (General)
OS: Mac OS X → Linux
QA Contact: release → catlee
Whiteboard: [buildbot]
(Assignee)

Updated

4 years ago
Product: mozilla.org → Release Engineering
This bug has sat for 3 years, I'm going to assume it's not an issue anymore..
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.