593872 - Send events for when tabs become pinned/unpinned

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Ian Gilman [:iangilman]]

Panorama needs it for app tab support (bug 593871). 

zpao has already written some code for this: 

https://bugzilla.mozilla.org/attachment.cgi?id=469553&action=diff#a/browser/base/content/tabbrowser.xml_sec1

... though we don't need the aSecondary stuff, just the 6 event lines. 

Drop it in, add a test, and r? dao.

Comment 1

[Ian Gilman [:iangilman]]

the event should go in here:

http://hg.mozilla.org/mozilla-central/file/tip/browser/base/content/test/browser_pinnedTabs.js

Comment 2

[(no longer active)]

Attachment: Patch (v1)

Comment 3

[Ian Gilman [:iangilman]]

We're hoping to get the feature this blocks (bug 593871) into beta6.

Comment 4

[(no longer active)]

Beltzner, please see comment 3.

Comment 5

[(no longer active)]

Attachment: Patch (v2)

Addressed Gavin's IRC comments...

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 473751 [details] [diff] [review]
Patch (v2)

We should probably add a _fireTabEvent helper at some point...

Comment 7

[(no longer active)]

Attachment: For check-in

Comment 8

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/fc0b88873756

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 473751 [details] [diff] [review]
Patch (v2)

When I hear "TabPin" it's not obvious to me that "pin" is a verb. Would have preferred "TabPinned".

Comment 10

[(no longer active)]

(In reply to comment #9)
> Comment on attachment 473751 [details] [diff] [review]
> Patch (v2)
> 
> When I hear "TabPin" it's not obvious to me that "pin" is a verb. Would have
> preferred "TabPinned".

Filed follow-up bug 595304.

Comment 11

[Dietrich Ayala (:dietrich)]

posthumous blocking+ since it blocks a blocker.

Comment 12

[Eric Shepherd [:sheppy]]

These got documented when I covered bug 595304.