593898 - MOZ_ACCELERATED=1 or layers.accelerated-all does not work anymore on widget QT

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Oleg Romashin (:romaxa)]

After recent changes in MOZ_ACCELERATED  value handler GL enabler stopped working in Qt widget.
There are 2 problems:
1) nsWindow::SetAccelerated is not called anymore (need for Qt to enable QGLWidget before GL context creation)
2) mUseAccelerated need to be set to toplevel window, otherwise..

Comment 1

[Oleg Romashin (:romaxa)]

I think this come from bug 590599

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: Call nsWindow::SetAccelerated before GLManagerCreated

I think we can also remove PREFS and MOZ_ACCELERATED values reading from http://mxr.mozilla.org/mozilla-central/source/widget/src/windows/nsWindow.cpp#3177

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+    PRBool newAcceleratedValue = PR_FALSE;
     if (disableAcceleration || safeMode)
-      mUseAcceleratedRendering = PR_FALSE;
+      newAcceleratedValue = PR_FALSE;
     else if (accelerateByDefault)
-      mUseAcceleratedRendering = PR_TRUE;
+      newAcceleratedValue = PR_TRUE;
+
+    if (newAccelValue != mUseAcceleratedRendering)
+      SetAcceleratedRendering(newAcceleratedValue);

This doesn't seem right. You're going to override any other setting of SetAcceleratedRendering, e.g. if the window has the 'accelerated' attribute.

Can't you move whatever QGL stuff you need to do into context creation?

Comment 4

[Oleg Romashin (:romaxa)]

Attachment: Fix QGL init for Qt port

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think the code in nsBaseWidget::GetLayerManager that checks prefs and environment should move to SetLayerManager so that mUseAcceleratedRendering is always correct.

Then, I think you can just call GetAcceleratedRendering from nsWindow::createQWidget. Although, does that happen before we call SetAcceleratedRendering from nsXULWindow? If so, then I guess you have to give up on supporting the 'accelerated' attribute. If that's OK, then I suggest you add a call to SetAcceleratedRendering(PR_FALSE) somewhere before you call GetAcceleratedRendering to ensure that the prefs and environment are consulted.

Comment 6

[Oleg Romashin (:romaxa)]

(In reply to comment #5)
> I think the code in nsBaseWidget::GetLayerManager that checks prefs and
> environment should move to SetLayerManager so that mUseAcceleratedRendering is

SetLayerManager - it is gfx/layers code IIUC? do we really want to keep prefs check code there?

> Then, I think you can just call GetAcceleratedRendering from
> nsWindow::createQWidget. Although, does that happen before we call

GetAcceleratedRendering - just return mUseAcceleratedRendering right now.

and someone should call SetAcceleratedRendering to set that as true.

Comment 7

[Oleg Romashin (:romaxa)]

Attachment: Simple version

Ok MOZ_ACCELERATED stuff has been fixed...
And now we only need to enable QGLWidget with Qt GL context when MOZ_ACCELERATED==1

Comment 8

[Doug Turner (:dougt)]

Comment on attachment 475266 [details] [diff] [review]
Simple version

plz add a comment above the test. 

no need to set Qt::WA_PaintOnScreen or Qt::WA_NoSystemBackground on the widget?

Comment 9

[Oleg Romashin (:romaxa)]

no, Qt::WA flags are not needed anymore

Comment 10

[Oleg Romashin (:romaxa)]

a=npodb

Comment 11

[Oleg Romashin (:romaxa)]

Pushed
http://hg.mozilla.org/mozilla-central/rev/0d1a15478360