Unused variable and initializer ordering compiler warnings with wasPreloadNone, mPreloadAction

RESOLVED FIXED

Status

()

Core
Audio/Video
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: cajbir, Assigned: cpearce)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Bug 548523 landed introducing these compiler warnings:

content/html/content/src/nsHTMLMediaElement.cpp: In member function ‘void nsHTMLMediaElement::UpdatePreloadAction()’:
content/html/content/src/nsHTMLMediaElement.cpp:874: warning: unused variable ‘wasPreloadNone’
../../../../dist/include/nsHTMLMediaElement.h: In constructor ‘nsHTMLMediaElement::nsHTMLMediaElement(already_AddRefed<nsINodeInfo>, PRUint32)’:
../../../../dist/include/nsHTMLMediaElement.h:677: warning: ‘nsHTMLMediaElement::mShuttingDown’ will be initialized after
../../../../dist/include/nsHTMLMediaElement.h:577: warning:   ‘nsHTMLMediaElement::PreloadAction nsHTMLMediaElement::mPreloadAction’
content/html/content/src/nsHTMLMediaElement.cpp:1270: warning:   when initialized here


See bug 548523 comment 24 where they were mentioned but must have been missed when the bug was re-landed.
(Assignee)

Comment 1

8 years ago
Created attachment 473925 [details] [diff] [review]
Patch
Assignee: nobody → chris
Attachment #473925 - Flags: review?(chris.double)
(Reporter)

Updated

8 years ago
Attachment #473925 - Flags: review?(chris.double) → review+
(Assignee)

Comment 2

8 years ago
Comment on attachment 473925 [details] [diff] [review]
Patch

Requesting approval2.0 for this patch. It's a safe patch to take.
Attachment #473925 - Flags: approval2.0?
(Assignee)

Comment 3

8 years ago
http://hg.mozilla.org/mozilla-central/rev/ed0b52948de6
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.