593942 - Print dialog laid out badly in right-to-left windows

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Simon Montagu :smontagu]

Attachment: Print dialog in Hebrew

The radio buttons in the "print frames" section of the print dialog are aligned somewhere in the middle of the box instead of to the right of it as expected. They are aligned correctly relatively to one another, so at least some kind of right-to-left processing is happening.

The bug can be reproduced on Hebrew Windows XP, either in the Hebrew localization or by setting intl.uidirection.en-US to "rtl" in about:config. It's probable that it won't be reproducable in a non-localized version of Windows, though.

Comment 1

[Jim Mathies [:jimm]]

Is this one of the system windows we used a surrogate parent on?

Comment 2

[Simon Montagu :smontagu]

Yes. 

In the meantime I located where the problem is - PrintHookProc in http://mxr.mozilla.org/mozilla-central/source/embedding/components/printingui/src/win/nsPrintDialogUtil.cpp sizes and positions the custom controls relative to the existing controls in the system dialog.

It needs to detect the window direction and do stuff like
 rect.SetRect(rad1Rect.right - rbWidth, y, rbWidth,radHgt);
instead of
 rect.SetRect(rad1Rect.left, y, rbWidth,radHgt);
in the RTL case

The position of the "print frames" group box and the OK and Cancel buttons also needs to change.

I can take this, but I probably won't get to it before next week.

Comment 3

[Simon Montagu :smontagu]

Attachment: patch

The fix was easier than I expected, for a change ;-)

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 472970 [details] [diff] [review]
patch

code looks ok to me, although I'm not a peer in embedding. I'm a little confused as to why this is in embedding, don't we have print dialog code in widget as well?)

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 472970 [details] [diff] [review]
patch

a2.0=dbaron

Comment 6

[Simon Montagu :smontagu]

http://hg.mozilla.org/mozilla-central/rev/74b45eeff9d6