test_history_store shoudn't use hardcoded timestamps

RESOLVED FIXED

Status

Cloud Services
Firefox Sync: Backend
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: philikon, Assigned: philikon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

If the history entries are too old, the history engine's queries won't find them anymore as we only query the last 30 days.
Created attachment 472619 [details] [diff] [review]
v1
Assignee: nobody → philipp
Attachment #472619 - Flags: review?(mconnor)

Updated

8 years ago
Attachment #472619 - Flags: review?(mconnor) → review+
http://hg.mozilla.org/services/fx-sync/rev/c18a3d025902
Blocks: 590633
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
how do we get this landed on mozilla-central for the xpcshell tests?
(In reply to comment #3)
> how do we get this landed on mozilla-central for the xpcshell tests?

We hope to merge again real soon (bug 590633). If that's not soon enough, we can land this individual fix sooner.
would it be ok to land the changes to this specific file as part of another patch in bug 591325 (fixing a regression from bug 586754)?
(In reply to comment #5)
> would it be ok to land the changes to this specific file as part of another
> patch in bug 591325 (fixing a regression from bug 586754)?

You could just import my patch into your queue... ;)
You need to log in before you can comment on or make changes to this bug.