Closed Bug 594059 Opened 14 years ago Closed 14 years ago

IPDL C++ unit tests broken on 1.9.2: TestLatency doesn't compile

Categories

(Core :: IPC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- .13-fixed
status1.9.1 --- wontfix

People

(Reporter: cjones, Assigned: cjones)

Details

Attachments

(1 file)

The problem is that TestLatency was switched to use new TimeDuration APIs (Resolution() and ToSecondsSigDigits()), but those weren't backported to 1.9.2.

In file included from /home/cjones/mozilla/1.9.2-mozilla/ipc/ipdl/test/cxx/TestLatency.cpp:2:
/home/cjones/mozilla/1.9.2-mozilla/ipc/ipdl/test/cxx/TestLatency.h: In member function ‘virtual void mozilla::_ipdltest::TestLatencyParent::ActorDestroy(mozilla::ipc::IProtocolManager<mozilla::ipc::AsyncChannel::AsyncListener>::ActorDestroyReason)’:
/home/cjones/mozilla/1.9.2-mozilla/ipc/ipdl/test/cxx/TestLatency.h:42: error: ‘class mozilla::TimeDuration’ has no member named ‘ToSecondsSigDigits’
/home/cjones/mozilla/1.9.2-mozilla/ipc/ipdl/test/cxx/TestLatency.h:43: error: ‘class mozilla::TimeDuration’ has no member named ‘ToSecondsSigDigits’
/home/cjones/mozilla/1.9.2-mozilla/ipc/ipdl/test/cxx/TestLatency.cpp: In member function ‘void mozilla::_ipdltest::TestLatencyParent::Main()’:
/home/cjones/mozilla/1.9.2-mozilla/ipc/ipdl/test/cxx/TestLatency.cpp:34: error: ‘Resolution’ is not a member of ‘mozilla::TimeDuration’
/home/cjones/mozilla/1.9.2-mozilla/ipc/ipdl/test/cxx/TestLatency.cpp: In member function ‘virtual bool mozilla::_ipdltest::TestLatencyParent::RecvPong()’:
/home/cjones/mozilla/1.9.2-mozilla/ipc/ipdl/test/cxx/TestLatency.cpp:81: error: ‘class mozilla::TimeDuration’ has no member named ‘ToSecondsSigDigits’
/home/cjones/mozilla/1.9.2-mozilla/ipc/ipdl/test/cxx/TestLatency.cpp: In member function ‘virtual bool mozilla::_ipdltest::TestLatencyParent::RecvPong5()’:
/home/cjones/mozilla/1.9.2-mozilla/ipc/ipdl/test/cxx/TestLatency.cpp:102: error: ‘class mozilla::TimeDuration’ has no member named ‘ToSecondsSigDigits’
make[7]: *** [TestLatency.o] Error 1
TestLatency doesn't check anything that's going to be regressed on 1.9.2., so instead of trying to backport the TimeDuration changes or fixing the test, this patch just turns it off.
Attachment #472664 - Flags: review?(benjamin)
Attachment #472664 - Flags: review?(benjamin) → review+
Comment on attachment 472664 [details] [diff] [review]
Disable TestLatency to allow building with --enable-ipdl-tests on 1.9.2 again

Would like this on 1.9.2 so that we can check for regressions in our IPC code using the IPDL C++ tests.  There's absolutely zero risk in this patch: the tests are NPOTB.
Attachment #472664 - Flags: approval1.9.2.10?
Attachment #472664 - Flags: approval1.9.2.11? → approval1.9.2.11+
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/6c6d174cf345
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
This missed the 1.9.2.11 release, fixed in 1.9.2.12 I guess.
Comment on attachment 472664 [details] [diff] [review]
Disable TestLatency to allow building with --enable-ipdl-tests on 1.9.2 again

Fixing approval flags to keep our triage queries happy.
Attachment #472664 - Flags: approval1.9.2.12+
Attachment #472664 - Flags: approval1.9.2.11-
Attachment #472664 - Flags: approval1.9.2.11+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: