594066 - [hy-AM] Revert e6385126a849

Status: RESOLVED FIXED

(Mozilla Localizations :: hy-AM / Armenian, defect, P2)

Description

[Axel Hecht [:Pike]]

http://hg.mozilla.org/l10n-central/hy-AM/rev/e6385126a849 landed a ton of crap.

Please, be *way* more careful.

Comment 1

[Armen [:armenzg]]

Done.
http://hg.mozilla.org/l10n-central/hy-AM/rev/e3bca8e0933f

I will have to do another import with more care. Let's see if I find the correct option on Narro.

It would be nice to have a tool to tell me if my locale is in a healthy way or a documented way to import from Narro into Mercurial repository. do you know of anyone who might have blogged this?

Comment 2

[Armen [:armenzg]]

Could I use compare-locales to compare with other locales?

Comment 3

[Axel Hecht [:Pike]]

That tool is called 'hg'. Whatever you use to edit source code, in the end, you should verify that the changes that toolchain made to the source are those that you intended.

Comment 4

[Armen [:armenzg]]

I import from Narro and don't edit the source code myself.
This is what I do to get the code into a working state:
1) fix the chmod
2) re-add the licenses

The localizers do the translation and I import it as best as I can. I don't know which files are supposed to be where I am learning as I am doing as I don't know where I could read more on what not to do. I might be dumb but I am trying as best as I can.

From http://bitbucket.org/armenzg/firefox-in-armenian/issue/29/narro-import-sep-6th-2010:
find . -type f -exec chmod -x {} \;
modules=( browser dom extensions netwerk other-licenses security toolkit ); for module in ${modules[@]}; do cd $module; for file in `find . -name "*dtd" -type f`; do cat /Users/armenzg/moz/armenian/patches/headers/header.dtd $file > $file.new; mv $file.new $file; done; for file in `find . -name "*properties" -type f`; do cat /Users/armenzg/moz/armenian/patches/headers/header.properties $file > $file.new; mv $file.new $file; done; cd ..; done

Comment 5

[Axel Hecht [:Pike]]

Thanks for doing the dance to make our legals do the happy dance each time. Feel free to file a bug on narro to not have to do that, too.

FWIW, here's what I think you did at some point: Download the wrong file (langpack instead of source), unpacked it in the source, and run hg addremove on the tree without checking that your toolchain produced the right results.

There's really no better tool than your favorite version control to verify that the toolchain you're using to edit the localized file did not horribly break anything.

Generally, doing hg addremove without being explicit on which files you're adding is a bad idea unless you actually verified with hg status that that's the right thing. Anything you hg add should either be required by compare-locales against en-US, or be tracked by a bug, probably with a patch.

Comment 6

[Armen [:armenzg]]

I tried again by doing a selective addition.
You can read more in http://bitbucket.org/armenzg/firefox-in-armenian/issue/30/add-new-files-from-import-on-september-6th-issue


(In reply to comment #5)
> Thanks for doing the dance to make our legals do the happy dance each time.
> Feel free to file a bug on narro to not have to do that, too.
I will do so
> 
> FWIW, here's what I think you did at some point: Download the wrong file
> (langpack instead of source), unpacked it in the source, and run hg addremove
> on the tree without checking that your toolchain produced the right results.
>
Unfortunately Narro offers two files and both have their weirdness:
* https://l10n.mozilla.org/narro/data/import/14/Firefox%20Next%20(mozilla-central)-hy-AM.zip
* https://l10n.mozilla.org/narro/data/import/14/Firefox%20Next%20(mozilla-central)-hy-AM.xpi

Maybe I have to find a way to remove files from Narro.

> There's really no better tool than your favorite version control to verify that
> the toolchain you're using to edit the localized file did not horribly break
> anything.
> 
> Generally, doing hg addremove without being explicit on which files you're
> adding is a bad idea unless you actually verified with hg status that that's
> the right thing. Anything you hg add should either be required by
> compare-locales against en-US, or be tracked by a bug, probably with a patch.
compare-locale was my friend in here but telling me which files I have to add and creating a list to match against.

Comment 7

[Axel Hecht [:Pike]]

The .xpi is a language pack. That used to be more obvious in older versions of narro, seems that these days you just have to know. Also, in older versions, only project admins could do an actual export to a zip'ed source, and uncheck a box called "copy unhandled files", https://developer.mozilla.org/en/Localizing_with_Narro#Export. No idea if that's still available in today's version.

Sadly, yes, the narro zip export tends to have outdated files in it, no idea how to resolve that. Catch alexxed on irc and poke him, or file tickets on his google code project page.

Comment 8

[Armen [:armenzg]]

Axel could you help me figure out why some of the strings in http://hg.mozilla.org/l10n-central/hy-AM/rev/c35d0c2b81e2 were removed and how could I check for the same?

I have ported some of the changes on that changeset to Narro but I want to know why the following strings were removed:
* xpinstallPromptWarning=[Ծրարի անունը]
* externalProtocolPrompt=Այլ ծրագիրը պիտի աշխատացվի %1$S տիպի հղման հետ աշխատելու համար. Հարցումն ուղղված է՝.

How can I check myself what parsing problems they might these cause?

Comment 9

[Axel Hecht [:Pike]]

Actually, I removed those strings because their values had issues, so they needed new translations. Fine to add them back once they're fixed.

http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/browser.properties#25 has two params.

http://mxr.mozilla.org/mozilla-central/source/dom/locales/en-US/chrome/appstrings.properties#57 has a flock of params, too, as does http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/overrides/appstrings.properties#58, seems those two want to be consistent.

Comment 10

[Armen [:armenzg]]

I had planned to do such but I wanted to know if you had run any tool to discover those strings as compare-locales seems to output only information for missing/adding/deleting strings and files.

Hrmmm, it seems that there are more scripts in:
http://hg.mozilla.org/build/compare-locales/file/844d4ed299a8/scripts