594125 - add-ons search URL does not support sort=updated

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[Truman Smith [:truman]]

The URL for add-ons advanced search does not support a sort option for updated date.  sort=updated returns results without updated date and appears to be sorted with the keyword option

for example:
https://preview.addons.mozilla.org/en-US/firefox/search/?q=firebug&cat=all&lver=any&pid=1&sort=updated&pp=20&lup=&advanced=on

Comment 1

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

sort=updated isn't exposed in the UI, if we want to add it back into the UI, I'd be happy to fix this - but otherwise we're supporting an easter-egg of a search option.

Comment 2

[Justin Scott [:fligtar]]

(In reply to comment #1)
> sort=updated isn't exposed in the UI, if we want to add it back into the UI,
> I'd be happy to fix this - but otherwise we're supporting an easter-egg of a
> search option.

I thought Updated was a sort option everywhere. You are saying it hasn't been in search results?

Comment 3

[krupa raj[:krupa]]

I think we had an option to sort search results by "Date" where we showed the last updated date. This got changed to "Newest" which is the date the add-on was added.

Comment 4

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

(In reply to comment #2)
> (In reply to comment #1)
> > sort=updated isn't exposed in the UI, if we want to add it back into the UI,
> > I'd be happy to fix this - but otherwise we're supporting an easter-egg of a
> > search option.
> 
> I thought Updated was a sort option everywhere. You are saying it hasn't been
> in search results?

It was never in the mocks.  Nor did it make sense to have both Newest and Last Updated.

IMO we should do Updated and drop Newest.

Comment 5

[Justin Scott [:fligtar]]

I think Newest and Updated are both useful but I don't want to add too many tabs.

Let's replace Name with Updated and see what happens. Though I recall name being the most used sort I'm willing to experiment since we all think it's not useful.

Comment 6

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/jbalogh/zamboni/commit/26ec11f

I commented out the name stuff so we can easily add it back.

Comment 7

[krupa raj[:krupa]]

verified at https://preview.addons.mozilla.org/en-US/firefox/search/?q=&cat=all&lver=any&pid=1&sort=newest&pp=20&lup=1+year+ago&advanced=off