594164 - Test Pilot's CSS is using javascript-esque comments

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Test Pilot, defect, P1)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100907 Firefox/4.0b6pre
Build Identifier: 

When I clicked the More Info link in the notification about an upcoming study, I checked the error console, and it had a lot of warnings like "Expected declaration but found '/'. Skipped to next declaration.

Looking at the referenced file (chrome://testpilot/skin/css/screen-standalone.css), it looks like someone went through and tried to comment out lines, but they used "//" instead of "/* */".

It happens 11 times in that file.

Reproducible: Always

Actual Results:  
CSS file uses wrong style of comments, causing CSS parsing warnings.

Expected Results:  
CSS file uses CSS style of comments.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: v1

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 472803 [details] [diff] [review]
v1

Not sure who would be the one to review this, but you're more likely to know than me, at the very least.

Comment 3

[Jono Xia]

This is just me being a sloppy coder.  Thanks a lot for your patch, Wes!

Comment 4

[Jono Xia]

Merged Wes's patch in http://hg.mozilla.org/labs/testpilot/rev/ffd18887a635
Thanks!

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 472803 [details] [diff] [review]
v1

Clearing an old review request that doesn't matter anymore. 
Sorry for bugspam. :)