594173 - "Advanced > Use hardware acceleration when available" needs to control layers.accelerate-none pref

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Joe Drew (not getting mail)]

Right now the hardware acceleration pref is available only on Windows, and only controls the D2D status. We need to make it control the pref "layers.accelerate-none" as well, and have it apply to all platforms (but control the d2d pref only on Windows).

Comment 1

[:Felipe Gomes (needinfo for replies!)]

If the same checkbox controls two prefs on Windows, what would the Options dialog show if someone manually modifies only one of the prefs?

Does layers acceleration depend on d2d being enabled (or any other kind of combination)? Or all of the related prefs independent?

Comment 2

[Joe Drew (not getting mail)]

They're independent.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

So what about this:

the checkbox controls and reflects layers.accelerate-none on all platforms. In addition to that, on Windows, whenever the checkbox is ticked/unticked the value is synced to gfx.direct2d.disabled too.

So for most users it will always disabled hw layers and direct2d, and an advanced user can enable direct2d on about:config while keeping hw layers disabled through the options dialog

Comment 4

[Joe Drew (not getting mail)]

sounds great.

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch v1

Implemented as described on comment #3.

Picking Mano for review.

Comment 6

[Asaf Romano (gone)]

Comment on attachment 473746 [details] [diff] [review]
Patch v1

>+  updateHardwareAcceleration: function()
>+  {
>+#ifdef XP_WIN
>+    var pref = document.getElementById("layers.accelerate-none");
>+    try {
>+      var prefsvc = Components.classes["@mozilla.org/preferences-service;1"].
>+                    getService(Components.interfaces.nsIPrefService).
>+                    QueryInterface(Components.interfaces.nsIPrefBranch2);

Use Services.prefs. Also, you don't need to wrap set*Pref calls in try blocks.

r=mano.

Comment 7

[:Felipe Gomes (needinfo for replies!)]

http://hg.mozilla.org/mozilla-central/rev/094ae81d7f88