Closed Bug 594195 Opened 14 years ago Closed 14 years ago

Optimizations in texel conversion functions

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bjacob, Assigned: bjacob)

Details

Attachments

(1 file, 2 obsolete files)

Texel conversions optimizations
16.14 KB, patch
vlad
: review+
joe
: approval2.0+
Details | Diff | Splinter Review
Attached patch Texel conversions optimizations (obsolete) — — Splinter Review 
2 changes:

 * added __restrict qualifiers since source and destination never overlap. Allows the compiler to optimize using this assumption. __restrict known to be supported across all significant compilers (we use it in Eigen, that's how I know)

 * optimized scaleFactor computations (1 div instead of 2)

Discussing with the WebKit guys first, will ask for review here later.
Assignee: nobody → bjacob
Attached patch Texel conversions optimizations (obsolete) — — Splinter Review 
Updated.
Attachment #472832 - Attachment is obsolete: true
updated to apply.
Attachment #473007 - Attachment is obsolete: true
Attachment #483316 - Flags: review?(vladimir)
Attachment #483316 - Flags: approval2.0+
http://hg.mozilla.org/mozilla-central/rev/e2d4a9c551aa
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: