Closed
Bug 59420
Opened 24 years ago
Closed 24 years ago
XIM: always uses on-the-spot after ProfileManager is invoked
Categories
(Core :: Internationalization, defect, P3)
Tracking
()
VERIFIED
FIXED
mozilla0.9.2
People
(Reporter: ji, Assigned: masaki.katakai)
Details
(Keywords: inputmethod, intl)
Attachments
(2 files)
14.76 KB,
patch
|
Details | Diff | Splinter Review | |
14.88 KB,
patch
|
Details | Diff | Splinter Review |
On RH6.2-J, although XIM input style is changed to over-the-spot or off-the-spot
in prefs.js file,
XIM still works as the default style of on-the-spot.
A typo in the summary.
Summary: XIM: over-the-spot and off-the-spot are working on RH6.2-J → XIM: over-the-spot and off-the-spot are not working on RH6.2-J
Assignee | ||
Comment 3•24 years ago
|
||
I also found this problem yesterday.
Ji, I believe you start Mozilla via profileManager, right?
The input style is set to a global variable and *cached*. So
when the first session is profilneManager, it's set as "on-the-spot"
(default) because profileManager does not look for ~/.mozilla/../prefs.js.
The value is cached, so it will be used even for the next user's session.
The reasonable workaround is to set prefs in system files, e.g. unix.js.
Please re-assign to katakai@japan.sun.com.
After including one pref in unix.js, I got the following results:
1. off-the-spot still behaves as on-the-spot
2. over-the-spot behaves differently depending where you are entering Ja chars:
. In the URL bar, it behaves as off-the-spot at the first time when you turn
on the IME after setting the focus on the URL bar. But after you open a composer
window and go back to the Navigator window, it's working as on-the-spot.
. In the composer window, it's like on-the-spot except that the status window
shows right below the line you are typing.
Comment 6•24 years ago
|
||
>1.
"off-the-spot" is not supported on mozilla, so it fallbacks to "on-the-spot"
naturally. Use "separate" for root-window style.
>2.
The behaviour looks over-the-spot to me.
kinput2 shows status window just below the cursor location only when
over-ths-spot style is used.
As to 2a, a root window appears with over-the-spot setting. It's like
off-the-spot. But once you correct it in a composer window, you don't see the
root window again.
Assignee | ||
Comment 8•24 years ago
|
||
> 2. over-the-spot behaves differently depending where you are entering Ja chars:
> . In the URL bar, it behaves as off-the-spot at the first time when you turn
> on the IME after setting the focus on the URL bar. But after you open a composer
> window and go back to the Navigator window, it's working as on-the-spot.
This problem is http://bugzilla.mozilla.org/show_bug.cgi?id=53990.
> As to 2a, a root window appears with over-the-spot setting. It's like
> off-the-spot. But once you correct it in a composer window, you don't see the
> root window again.
ji, can you see the same separate(off-the-spot) window? What does "you correct
it" mean?
In my environment, I can not see a root window. over-the-spot seems to work fine
for me.
Assignee | ||
Comment 9•24 years ago
|
||
Assignee | ||
Comment 10•24 years ago
|
||
The patch also contains removing codes around InputPolicy.
Now InputPolicy is ic-per-shell as default.
Reporter | ||
Comment 11•24 years ago
|
||
The problem I encountered with over-the-spot seems to be reported in Bug 53990.
I'd like to keep this bug for enabling over-the-spot via prefs.js setting.
Assignee | ||
Comment 12•24 years ago
|
||
I'll update the bug after http://bugzilla.mozilla.org/show_bug.cgi?id=53989
is solved.
Status: NEW → ASSIGNED
Comment 14•24 years ago
|
||
Changed QA contact to ji@netscape.com since she knows this bug.
QA Contact: teruko → ji
Assignee | ||
Updated•24 years ago
|
Summary: XIM: over-the-spot and off-the-spot are not working on RH6.2-J → XIM: always uses on-the-spot after ProfileManager is invoked
Assignee | ||
Comment 15•24 years ago
|
||
I'll make new patch for the latest tree.
Target Milestone: --- → mozilla0.9.2
Assignee | ||
Comment 16•24 years ago
|
||
Assignee | ||
Comment 17•24 years ago
|
||
Chris,
I've attached the patch for review. I need your r=/sr=.
The problem, over-the-spot does not work after profileManager,
happens because we keep input style as static. Even when user
wants to use own setting in user's prefs, but at starting profile
manager (no user here), the input style is set to the default,
on-the-spot and is being used. gInputStyle should be in nsIMEGtkIC
class and needs to be retrieved for each IC creation.
I did in the patch,
- Move gInputStyle to nsIMEGtkIC::mInputStyle
- mInputStyle is retrieved by GetInputStyle() at each
nsIMEGtkIC creation
- refer xic->mInputStyle instead of gInputStyle
- Removed unnecessary around IMEPolicy
There is no way to support input policy (per widget or per shell)
because of Editor changes.
I did following testing on Solaris and Linux
- set user_pref("xim.input_style", "over-the-spot"); in prefs
- start Mozilla -profileManager
- select a profile and invoke Mozilla
Verify over-the-spot is working
Thank you.
Comment 18•24 years ago
|
||
r/sr=blizzard
Assignee | ||
Comment 19•24 years ago
|
||
fix checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 20•24 years ago
|
||
Verified with 05/31 trunk build (the build before the 0.9.1 branch)
It's fixed.
Status: RESOLVED → VERIFIED
Updated•15 years ago
|
Keywords: inputmethod
You need to log in
before you can comment on or make changes to this bug.
Description
•