594224 - All argument parameters of nsIMapi need "unique" directive

Status: RESOLVED FIXED

(MailNews Core :: Simple MAPI, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

Attachment: A test program to invoke Login() and SendDocuments()

All argument parameters of nsIMapi need "unique" directive because "pointer_default(unique)" does not affect those arguments.

See http://msdn.microsoft.com/en-us/library/ms690150%28VS.85%29.aspx
The document says:

  The pointer_default attribute specifies the default pointer type (unique, ref, or ptr) for all pointers except for those included in parameter lists. If no default type is specified, MIDL assumes that single pointers are unique. However, when you have multiple levels of pointers, you must explicitly specify a default pointer type, even if you want the default type to be unique.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Fix

Comment 2

[Hiroyuki Ikezoe (:hiro)]

This fix will fix bug 565041 and bug 558374.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Ooops, sorry. bug 565041 is actually not related to this issue.

Comment 4

[Ludovic Hirlimann [:Usul]]

(In reply to comment #1)
> Created attachment 472872 [details] [diff] [review]
> Fix

Does this work on windows XP ?

You are changing idl , without changing UUID ?

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Yes, it works on Windows XP.

I think changing attribute type does not need changing UUID, but I am not %100 sure so I have no objection to change UUID.

Comment 6

[Ludovic Hirlimann [:Usul]]

(In reply to comment #5)
> Yes, it works on Windows XP.
> 
> I think changing attribute type does not need changing UUID, but I am not %100
> sure so I have no objection to change UUID.

Please do, just to be safe.

Comment 7

[David :Bienvenu]

Comment on attachment 472872 [details] [diff] [review]
Fix

I don't think there's any reason to change the UUID - clients are using the external mapi interfaces, not the internal one.

Comment 8

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/b9feb6dbd2a9