59423 - Porting NSS 3.1 to Mac requires code changes..

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Javier Delgadillo]

I'm opening this bug as a tracking bug for the port of NSS 3.1

I'll be attaching a diff of the changes I've currently made.

Comment 1

[Javier Delgadillo]

Attachment: Patches required so far to port NSS...

Comment 2

[Javier Delgadillo]

One thing I should note, is that I haven't ported the loadable root cert code yet.

Comment 3

[Javier Delgadillo]

I will wait to check in these fixes until nelsonb fixes another bug in MPI.

Comment 4

[Javier Delgadillo]

Who's going to review this for inclusion into the NSS 3.1 branch?  Or since it's
already checked into the trunk, can I assume it's safe for the branch? (I highly
 doubt that though.)

I'm just waiting on someone from the NSSS team to say it's OK to check this into
the branch.

Comment 5

[Wan-Teh Chang]

Javi, is attachment id=18901 the exact patch you checked in?
Relyea, Nelson, or I can review the patch.  The patch must be
reviewed before it can be checked in on the NSS 3.1 branch.

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

One of the tasks on my plate is to review the changes that have been
made to NSS trunk since the NSS 3.1 branch was created to see which 
changes need to be merged onto the branch.  

I believe that all the MPI changes will be merged to the branch.
So, I propose to handle the merger of all MPI changes, including
Javi's, to the branch.  

That leaves the changes to macbuild/NSSCommon.h and 
pk11wrap/pk11sdr.c for someone to review.

Comment 7

[Terry Hayes]

I approve the changes to pk11sdr.c

Comment 8

[Wan-Teh Chang]

I approve the changes to macbuild/NSSCommon.h.

Comment 9

[Javier Delgadillo]

I'm currently trying to port my changes to the NSS 3.1 branch and have
encountered some problems I didn't see while porting the tip.  Hopefully the
changes are to my build environment and can be resolved without anymore code
changes.  

Regardless, once I get the branch port working I'll attach a new patch along
with all of the projects that have to be added to the branch to get loadable
root certs working as well.

Comment 10

[Javier Delgadillo]

Attachment: Diff for the NSS 3.1 branch

Comment 11

[Javier Delgadillo]

Ignore the the patch attached at 15:15, it's the original patch.  I'll attach
the branch patch soon.

Comment 12

[Javier Delgadillo]

Attachment: The real branch patch...

Comment 13

[Javier Delgadillo]

For some reason, once I started to work with a NSS_3_1_BRANCH, ULONG_MAX and
some other system defines were no longer being defined in the MPI file.  So the
diff for mpi.h is slightly different than the original diff, but everything else
should be the same.

The new patch also mentions which projects have to be carried over from the
trunk to the branch.

Comment 14

[Javier Delgadillo]

I figured out what I did wrong, turns out that I put the #include <limits.h> in
the ifdef block when I shouldn't have.  So MPI code diffs staty the same when
compared to what's currently checked into the tip of NSS.

The reviews that were approved by wtc and thayes have been checked in to the
branch.  The updated Mac projects were also added to the branch.  Once nelsonb
reviews and updates the MPI code to the branch, We'll be ready for a test of the
branch for use on a Mac.

Comment 15

[Nelson Bolyard (seldom reads bugmail)]

I merged all the MPI and SSL changes since the creation of the 
NSS_3_1_BRANCH from the trunk onto the branch.  
This fixes several problems, including the prime generation bug
and the lock bug in TLS.

Comment 16

[Nelson Bolyard (seldom reads bugmail)]

Javi,  I'm reassigning this to you because I think you already did
all the work for this, and this is now resolved/fixed. 
I expect you'll mark it resolved.  

Comment 17

[Javier Delgadillo]

nelsonb is correct, this was fixed a while back.