Closed Bug 594241 Opened 14 years ago Closed 14 years ago

Can't disable history sync

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: philikon, Assigned: philikon)

References

Details

Attachments

(1 file)

History and forms share the same pref which confuses Weave.Service._updateEnabledEngines() (introduced by bug 578671). As a result, history sync can't be turned off.
Attached patch v1Splinter Review
Take engine.prefName rather than engine.name when looking for changed prefs.
Assignee: nobody → philipp
Attachment #472908 - Flags: review?(mconnor)
Attachment #472908 - Flags: review?(mconnor) → review+
http://hg.mozilla.org/services/fx-sync/rev/6fd31afe010f
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: