On Hebrew Windows common dialogs appear in Hebrew, even in English Firefox

RESOLVED FIXED in mozilla2.0b7

Status

()

Core
Widget: Win32
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: smontagu, Assigned: smontagu)

Tracking

({regression, rtl})

Trunk
mozilla2.0b7
x86
Windows XP
regression, rtl
Points:
---

Firefox Tracking Flags

(blocking2.0 -)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 472959 [details] [diff] [review]
Patch

Oops
Attachment #472959 - Flags: review?(jmathies)
(Assignee)

Updated

7 years ago
Summary: On Hebrew windows common dialogs appear in Hebrew even in English Firefox → On Hebrew Windows common dialogs appear in Hebrew, even in English Firefox
(Assignee)

Updated

7 years ago
blocking2.0: --- → ?

Updated

7 years ago
Attachment #472959 - Flags: review?(jmathies) → review+

Comment 1

7 years ago
Your indent looks off by one.

Comment 2

7 years ago
Hah!  This is why I would require compilation errors on anything which relies on operator precedence in the languages that I'm going to design in a distant future... :-)

Updated

7 years ago
Keywords: regression
(Assignee)

Updated

7 years ago
Attachment #472959 - Flags: approval2.0?
Comment on attachment 472959 [details] [diff] [review]
Patch

Is adding back the WS_EX_NOACTIVATE risky?

a2.0=dbaron
Attachment #472959 - Flags: approval2.0? → approval2.0+

Updated

7 years ago
blocking2.0: ? → -
(Assignee)

Comment 4

7 years ago
http://hg.mozilla.org/mozilla-central/rev/b1d56e69f4d9

(In reply to comment #3)
> Is adding back the WS_EX_NOACTIVATE risky?

It doesn't seem to make any difference one way or the other, so I just took it out.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Target Milestone: --- → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.