Update the live filter search button in Panorama UI

VERIFIED FIXED in Firefox 4.0b8

Status

Firefox Graveyard
Panorama
P2
normal
VERIFIED FIXED
7 years ago
a year ago

People

(Reporter: raymondlee, Assigned: raymondlee)

Tracking

unspecified
Firefox 4.0b8
Dependency tree / graph

Details

(Whiteboard: [good first bug])

Attachments

(2 attachments, 3 obsolete attachments)

Comment hidden (empty)
(Assignee)

Updated

7 years ago
Depends on: 592045
Priority: -- → P2
Whiteboard: [good first bug]
Do we know what the problem might be? Raymond, please assign to Aza for design once you've provided more info.
Assignee: nobody → raymond
(Assignee)

Comment 2

7 years ago
Created attachment 476478 [details]
Screenshot of search button

The magnify glass isn't very visible.
(Assignee)

Updated

7 years ago
Assignee: raymond → aza
OS: Windows Vista → Windows 7

Updated

7 years ago
Assignee: aza → smartell
Blocks: 598154
OS: Windows 7 → Windows XP
Target Milestone: --- → Firefox 4.0

Comment 3

7 years ago
Assigning to Sean Martell, as he is handling the creation of those glyphs.

Updated

7 years ago
Depends on: 597269

Comment 4

7 years ago
In the latest mockups, I've replaced the search glyph with one that matches the overall glyph style within FF4:

http://mozilla.seanmartell.com/tabcandy/index.html
http://mozilla.seanmartell.com/tabcandy/index-win2.html

Comment 5

7 years ago
Thanks Sean, those look snazzy.

Raymond, can you implement?
Assignee: smartell → raymond
OS: Windows XP → All
(Assignee)

Updated

7 years ago
Summary: Ensure live filter search in Panorama UI looks good on Windows → Update the live filter search button in Panorama UI
(Assignee)

Comment 6

7 years ago
Created attachment 489445 [details] [diff] [review]
v1
Attachment #489445 - Flags: feedback?(ian)
(Assignee)

Updated

7 years ago
Status: NEW → ASSIGNED
Comment on attachment 489445 [details] [diff] [review]
v1

Looks fine
Attachment #489445 - Flags: feedback?(ian) → feedback+
(Assignee)

Updated

7 years ago
Attachment #489445 - Flags: review?(dao)
Comment on attachment 489445 [details] [diff] [review]
v1

Use -moz-margin-end instead of margin-right.
Attachment #489445 - Flags: review?(dao) → review+
(Assignee)

Comment 9

7 years ago
Created attachment 489819 [details] [diff] [review]
v1

Replaced -moz-margin-end with margin-right.

a=dao
Attachment #489445 - Attachment is obsolete: true
Attachment #489819 - Flags: approval2.0?
(In reply to comment #9)
> Created attachment 489819 [details] [diff] [review]
> v1
> 
> Replaced -moz-margin-end with margin-right.
> 
> a=dao

That should be r=dao. 

Does it need a try run?
(Assignee)

Comment 11

7 years ago
(In reply to comment #10)
> (In reply to comment #9)
> > Created attachment 489819 [details] [diff] [review] [details]
> > v1
> > 
> > Replaced -moz-margin-end with margin-right.
> > 
> > a=dao
> 
> That should be r=dao. 
> 
> Does it need a try run?

I don't think we need a try run because the patch just updates some CSS.
(In reply to comment #11)
> 
> I don't think we need a try run because the patch just updates some CSS.

Fair enough.
Marking blocking, approval not needed.
blocking2.0: --- → final+
Attachment #489819 - Flags: approval2.0?
(Assignee)

Comment 14

7 years ago
Created attachment 492670 [details] [diff] [review]
Patch for check-in
Attachment #489819 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/88cca1740749
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
This bug was part of a mass backout to fix the permanent leak on OS X 64 that this push caused.

http://hg.mozilla.org/mozilla-central/rev/b014423f755b
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 17

7 years ago
Created attachment 493171 [details] [diff] [review]
Patch for check-in
Attachment #492670 - Attachment is obsolete: true
(Assignee)

Comment 18

7 years ago
Sent it to try and passed with intermittent orange.
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/98184990f3ba
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: Firefox 4.0 → Firefox 4.0b8
Verified in recent nightly minefield build
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.