Closed Bug 594429 Opened 10 years ago Closed 10 years ago
Update the live filter search button in Panorama UI
No description provided.
Priority: -- → P2
Whiteboard: [good first bug]
Do we know what the problem might be? Raymond, please assign to Aza for design once you've provided more info.
Assignee: nobody → raymond
The magnify glass isn't very visible.
Assignee: raymond → aza
OS: Windows Vista → Windows 7
Assignee: aza → smartell
OS: Windows 7 → Windows XP
Target Milestone: --- → Firefox 4.0
Assigning to Sean Martell, as he is handling the creation of those glyphs.
In the latest mockups, I've replaced the search glyph with one that matches the overall glyph style within FF4: http://mozilla.seanmartell.com/tabcandy/index.html http://mozilla.seanmartell.com/tabcandy/index-win2.html
Thanks Sean, those look snazzy. Raymond, can you implement?
Assignee: smartell → raymond
OS: Windows XP → All
Summary: Ensure live filter search in Panorama UI looks good on Windows → Update the live filter search button in Panorama UI
Comment on attachment 489445 [details] [diff] [review] v1 Looks fine
Attachment #489445 - Flags: feedback?(ian) → feedback+
Comment on attachment 489445 [details] [diff] [review] v1 Use -moz-margin-end instead of margin-right.
Attachment #489445 - Flags: review?(dao) → review+
Replaced -moz-margin-end with margin-right. a=dao
(In reply to comment #9) > Created attachment 489819 [details] [diff] [review] > v1 > > Replaced -moz-margin-end with margin-right. > > a=dao That should be r=dao. Does it need a try run?
(In reply to comment #10) > (In reply to comment #9) > > Created attachment 489819 [details] [diff] [review] [details] > > v1 > > > > Replaced -moz-margin-end with margin-right. > > > > a=dao > > That should be r=dao. > > Does it need a try run? I don't think we need a try run because the patch just updates some CSS.
(In reply to comment #11) > > I don't think we need a try run because the patch just updates some CSS. Fair enough.
Marking blocking, approval not needed.
blocking2.0: --- → final+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
This bug was part of a mass backout to fix the permanent leak on OS X 64 that this push caused. http://hg.mozilla.org/mozilla-central/rev/b014423f755b
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Sent it to try and passed with intermittent orange.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 4.0 → Firefox 4.0b8
Verified in recent nightly minefield build
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.