The default bug view has changed. See this FAQ.

Package message wakeup service

RESOLVED FIXED in seamonkey2.1b1

Status

SeaMonkey
Build Config
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Robert Kaiser, Assigned: sgautherie)

Tracking

Trunk
seamonkey2.1b1
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
Message wakeup service is appearing in package-compare as not being packaged, and I thought we could ignore it as long as we don't do e10s, but Serge has found that it appears in Mac leak test assertions now (bug 563643), so we should really do the packaging.
I'm hesitant to mark a bug dependency here or attach it there as this one might just mask the problem we already had there earlier.
(Assignee)

Comment 1

7 years ago
Created attachment 473145 [details] [diff] [review]
(Av1) Just fo it

To fix
{
+bin/components/messageWakeupService.js
+bin/components/messageWakeupService.manifest
}
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #473145 - Flags: review?(kairo)
(Assignee)

Comment 2

7 years ago
Fwiw, Firefox does not (explicitly) package these files :-/
Depends on: 591052
Flags: in-testsuite-
Version: unspecified → Trunk
(Assignee)

Updated

7 years ago
Depends on: 594487
(Reporter)

Updated

7 years ago
Attachment #473145 - Flags: review?(kairo) → review+
Shouldn't we prefer the solution from bug 594487?
(Reporter)

Comment 4

7 years ago
Firefox is no measure any more because they use omnijar packaging.
(Reporter)

Comment 5

7 years ago
But Aqualon might be right, actually - for the moment, as once we enable libxul and OOPP, we'll want it packaged.
(Assignee)

Comment 6

7 years ago
(In reply to comment #3)
> Shouldn't we prefer the solution from bug 594487?

"No", we likely (will) need both.

(In reply to comment #4)
> Firefox is no measure any more because they use omnijar packaging.

Well, they (explicitly) package other similar files, but anyway...

(In reply to comment #5)
> once we enable libxul and OOPP, we'll want it packaged.

Yes, I'll check an updated patch in, depending on bug 594487 fix.
Comment on attachment 473145 [details] [diff] [review]
(Av1) Just fo it

I don't want this, and want Bug 593613 instead.

If you feel like doing this change now though, I'll accept it if you wrap it in:
ifdef MOZ_IPC

Thanks
Attachment #473145 - Flags: review-
(Assignee)

Comment 8

7 years ago
(In reply to comment #7)

> I don't want this, and want Bug 593613 instead.

Wrong bug number?

> If you feel like doing this change now though, I'll accept it if you wrap it
> in:
> ifdef MOZ_IPC

That's exactly what I meant in my comment 6...
Whiteboard: [waiting for bug 594487 check-in first]
(Assignee)

Updated

7 years ago
Attachment #473145 - Attachment is obsolete: true
Attachment #473145 - Flags: review-
(Assignee)

Comment 9

7 years ago
Created attachment 476601 [details] [diff] [review]
(Av2) Just do it
[Checked in: Comment 10]

Av1, with comment 6 suggestion(s).
Attachment #476601 - Flags: review?(bugspam.Callek)

Updated

7 years ago
Attachment #476601 - Flags: review?(bugspam.Callek) → review+
(Assignee)

Comment 10

7 years ago
Comment on attachment 476601 [details] [diff] [review]
(Av2) Just do it
[Checked in: Comment 10]

http://hg.mozilla.org/comm-central/rev/87914d492ab4
Attachment #476601 - Attachment description: (Av2) Just do it → (Av2) Just do it [Checked in: Comment 10]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [waiting for bug 594487 check-in first]
Target Milestone: --- → seamonkey2.1b1
(Assignee)

Updated

7 years ago
Depends on: 598916
You need to log in before you can comment on or make changes to this bug.