Closed
Bug 594455
Opened 14 years ago
Closed 14 years ago
[meta] DefaultCompartment fixes
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: gwagner, Assigned: gwagner)
References
Details
Attachments
(2 files, 3 obsolete files)
19.39 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
20.85 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•14 years ago
|
Assignee | ||
Comment 1•14 years ago
|
||
Asserting at the API boundary that we don't enter with the defaultCompartment.
Comment 2•14 years ago
|
||
Gregor, I think the assertion in JS_IsAboutToBeCollected is bogus. Please rip that out and later today I'll remove any JSAutoCrossCompartmentCalls we've added in GC callbacks.
Comment 3•14 years ago
|
||
Hope everyone agrees this isn't a productive thing to be doing.
Attachment #474146 -
Flags: review?(gal)
Updated•14 years ago
|
Attachment #474146 -
Flags: review?(gal) → review+
Assignee | ||
Comment 4•14 years ago
|
||
refresh of api asserts: JS_ASSERT(cx->compartment != cx->runtime->defaultCompartment);
Assignee | ||
Comment 5•14 years ago
|
||
I pass now all the xpcshell tests on my machine (Mac) with all the various defaultCompartment fixes. Tryserver for windows and linux indicates another mixup in TEST-INFO | e:\builds\moz2_slave\tryserver-win32-debug-unittest-xpcshell\build\xpcshell\tests\chrome\test\unit_ipc\test_resolve_uris_ipc.js | It looks like the last one :)
Comment 6•14 years ago
|
||
file it, I can fix
Assignee | ||
Comment 7•14 years ago
|
||
I pushed the API assertion patch to tryserver and I don't see assertions any more. Looks like we fixed all defaultCompartment mixups that are covered by the testcases!
Assignee | ||
Comment 8•14 years ago
|
||
Maybe we should land some assertions in jsapi for the future.
Attachment #473176 -
Attachment is obsolete: true
Attachment #474146 -
Attachment is obsolete: true
Attachment #478934 -
Attachment is obsolete: true
Attachment #479972 -
Flags: review?(jorendorff)
Assignee | ||
Updated•14 years ago
|
Assignee: general → anygregor
Comment 9•14 years ago
|
||
Comment on attachment 479972 [details] [diff] [review] patch The original idea was that non-JS_THREADSAFE embeddings could ignore compartments entirely and use the default compartment for everything. That way we only break JS_THREADSAFE embedders. If you think that would work, please make the asserts JS_THREADSAFE-only. (I think all JS_THREADSAFE embeddings will want to avoid the default compartment for the same reasons we do.) r=me with that.
Attachment #479972 -
Flags: review?(jorendorff) → review+
Assignee | ||
Comment 10•14 years ago
|
||
Something like this with JS_THREADSAFE_ASSERT?
Comment 11•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/1283831c28bf
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•