594503 - Group Your Tabs (Panoroma) button should have a button press indicator

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect)

Description

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b6pre) Gecko/20100908 Firefox/4.0b6pre

Currently top level icons such as the 'List all Tabs', and the 'New Tab button have a visual indicator on mouse click where it turns to a blue state when a class is applied. 

The Group Your Tabs icon currently does not have an indicator of the same style nor applied class. To be consistent, this icon should have the same indicator on mouse press.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: v0

Changes tabview.png to have an active state, and adds a (really ugly) CSS :hover:active selector to show that active state, for winstripe and pinstripe. (I didn't see that gnomestripe used :active for buttons like the other did, so I left it alone.) ((Plus, tabview.png is 4px smaller on gnomestripe, so I'd have to redo my really ugly change to that image file))

Comment 2

[Aaron Train [:aaronmt]]

Is this class state for buttons even still desired with a refresh? It seems like there are very few items which have this state

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

That "(really ugly)" should have been referencing the image file, not the CSS.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Screenshot w/patch on Windows 7

Here's what the patch looks like on Windows 7 for me.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: v1

Updated to use the new tabview.png's multiple states.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Mac image

Apparently the Mac and Windows Panorama button images are differently sized.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Windows image

Comment 8

[Stephen Horlander [:shorlander]]

Attachment: Existing Active Glyph Style/Color

Thanks for doing this Wes! The images should be a little closer to the active style and color as the other active glyphs.

I am not sure what you are using for image editing but I have specific Photoshop styles for this which I can supply. Or I can just attach the images and you could roll them into your patch?

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to comment #8)
> Created attachment 474731 [details]
> Existing Active Glyph Style/Color
> 
> Thanks for doing this Wes! The images should be a little closer to the active
> style and color as the other active glyphs.
> 
> I am not sure what you are using for image editing but I have specific
> Photoshop styles for this which I can supply. Or I can just attach the images
> and you could roll them into your patch?

Yeah, I was just using GIMP's colorize tool to make them somewhat bluish.  Attaching the images would be great.

Comment 10

[Aza Raskin [:aza]]

Waiting for the new images.

Comment 11

[Stephen Horlander [:shorlander]]

Attachment: Mac Image

Also includes updated normal state for bug 595791

Comment 12

[Stephen Horlander [:shorlander]]

Attachment: Windows Image

Also includes updated normal state for bug 595791. Although the CSS still needs to be tweaked so that the icon doesn't get compressed on the tabstrip.

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to comment #12)
> Although the CSS still needs to be tweaked so that the icon doesn't get 
> compressed on the tabstrip.

Don't follow. Why would it get compressed on the tabstrip?

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: with new image files

This uses the same CSS as the previous patch. Not sure what needs to be done from here.

Comment 15

[Dão Gottwald [:dao]]

(In reply to comment #13)
> (In reply to comment #12)
> > Although the CSS still needs to be tweaked so that the icon doesn't get 
> > compressed on the tabstrip.
> 
> Don't follow. Why would it get compressed on the tabstrip?

The tabview button is missing from browser/themes/browserShared.inc.

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: v1 w/new images and browsershared.inc change

Same as previous patch, but adds #tabview-button to browserShared.inc.

Comment 17

[Ian Gilman [:iangilman]]

Comment on attachment 476248 [details] [diff] [review]
v1 w/new images and browsershared.inc change

I can't give this an official review; reassigning review to dietrich. 

Can someone verify that we don't need this on linux?

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to comment #17)
> Can someone verify that we don't need this on linux?

When I last checked my Ubuntu VM's trunk builds, none of the buttons had a click indicator style. Don't know if it's something intentional or if they just haven't progressed very far on the Linux theme work...

Comment 19

[Stephen Horlander [:shorlander]]

Linux does not have an indicator which is consistent with the other icons. The hover button has a click state.

Comment 20

[Aza Raskin [:aza]]

We need someone to give us a+.

Comment 21

[Michael Yoshitaka Erlewine [:mitcho]]

I assume this bug and patch doesn't apply (in both senses) anymore?

Comment 22

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 476248 [details] [diff] [review]
v1 w/new images and browsershared.inc change

Most likely bitrotten; removing approval. Renominate if desired!

Comment 23

[(no longer active)]

Doesn't apply cleanly anymore.

Comment 24

[Markus Amalthea Magnuson]

Someone should probably close this as a WONTFIX. The Tab Groups button is a standard toolbar button, and it seems none of these have the blue active state when put in the top level toolbar, except for the special ones (new tab, tab menu).