Closed Bug 594504 Opened 10 years ago Closed 10 years ago

Show a message to explain why downloads with no helper apps were cancelled

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: wesj, Assigned: wesj)

Details

Attachments

(1 file, 1 obsolete file)

Bug 592902 changed our default behavior so that downloads with no available helper app in the system are cancelled. We need to provide some UI to the user to explain what happened.
Attached patch Show a notification (obsolete) — Splinter Review
This shows a notification that the download was cancelled. It just says "Can not open file.foo". You can't click on it or anything either (except to hide it).
Attachment #473840 - Flags: review?(mark.finkle)
Comment on attachment 473840 [details] [diff] [review]
Show a notification


>+alertCantOpenDownload=Download Cancelled

"Canceled" appears to be used more in Mozilla code, in strings. So let's use it:
Download Canceled

>+alertCantOpenDownloadDetails=Can not open %S

Not my favorite string. We kinda want something like this:
http://mxr.mozilla.org/mozilla-central/source/dom/locales/en-US/chrome/nsWebBrowserPersist.properties#44

but that is to wordy for mobile. How about just:
%S could not be opened

r+ for the code. Let's get Madhava to review the strings.
Attachment #473840 - Flags: ui-review?(madhava)
Attachment #473840 - Flags: review?(mark.finkle)
Attachment #473840 - Flags: review+
How about

Cannot open file
Tap to save it, instead

and add the action of tapping on the alert (a) start (continue) the download and (b) move the user to the download manager, as tapping on the dl alerts always does.
Fixes as per notes. Download isn't cancelled until the notification disappears. Tapping saves it, and opens the download manager.
Attachment #473840 - Attachment is obsolete: true
Attachment #473840 - Flags: ui-review?(madhava)
Attachment #474105 - Flags: review?(mark.finkle)
Comment on attachment 474105 [details] [diff] [review]
Cancel notification

if (

not 

if(

and Madhava wanted the text to be:

alertCantOpenDownload=Cannot open file
alertCantOpenDownloadDetails=Tap to save file

I can change on checkin
Attachment #474105 - Flags: review?(mark.finkle) → review+
pushed with changes:
http://hg.mozilla.org/mobile-browser/rev/2e5a55d3b00a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
bugspam
Assignee: nobody → wjohnston
This issue is verified as fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110914
Firefox/9.0a1 Fennec/9.0a1
Device: HTC Desire
OS: Android 2.2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.