59451 - Custom installer's license.txt doesn't appear (WinNT&Win2000)

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect, P3)

Description

[bmartin]

Latest N6 CCK build dated: 2000-11-06-12

O/S: WinNT4.0 and Win2000

Steps:
1.Download, extract, and install contents of latest CCKInstaller.zip
2.Launch CCK
3.Create a customized build with CD Autorun Shell
4.Burn the customized build to a CDR
5.Launch the customized build's installer.
6.Proceed to the Software license Agreement dialog

Results:

The License.txt is not displayed.

Comment 1

[bmartin]

Marking M20 for tracking N6 CCK RTM

Comment 2

[varada]

I dont understand this bug. where are we collecting the license.txt and where
should we be displaying it?

Comment 3

[bmartin]

The license.txt should live within the setup.exe (and N6Setup.exe).  When this 
file is run, it's contents should be extracted to the system Temp\ directory.

Comment 4

[varada]

Re-assigning to jpatel.
The license.txt should be there in the N6Setup.zip

Comment 5

[bmartin]

re-assigning to Varada... the license file is included in the customized N6 
build.  However, the new setup.exe's config.ini is not displaying it in the 
License Agreement installer screen

Comment 6

[bmartin]

The license.txt file will appear in the License Agreement installer screen on 
Win95/98/Me systems.... this bug only exists on NT and 2000

Comment 7

[bmartin]

I created a build without the CD Autorun shell and the license.txt file doesn't 
appear in the installer on all win32 platforms.

Comment 8

[Sean Su]

Brent and I have found the problem and the fix for this bug.  We're working on 
checking it in right now.

Comment 9

[Sean Su]

Attachment: patch to fix this bug.

Comment 10

[Sean Su]

The problem was that the fopen() command was attempting to open the license file 
in a Read/Write mode, but since the CD is readonly, it fails.

The fix is very simple and safe.  Instead of opening the license file with 
"r+b", use "rb" instead.  (see patch above)

Reassigning this bug to myself.
(r=bmartin,sgehani)

Comment 11

[varada]

Mucho Obrigado to you Monsieur SU if you can get this checked in ASAP.

Comment 12

[Scott MacGregor]

sr=mscott

Comment 13

[bmartin]

I tested Sean's fix and have found the following:

The license.txt is not displayed on Win95/98/Me when the custom N6 CD Image 
doesn't include the CD Autorun shell.  

A customized build that doesn't contain the CD Autorun shell will have all the 
.xpi, readme.txt, license.txt, autorun.inf files exposed at the root of the CD 
media along with the installer's setup.exe.

If the custom N6 build includes a CD Autorun shell, the license will be display 
just fine on all Win32 platforms.

Comment 14

[Sean Su]

I'm attaching a second patch that will contain the fix for the problem of
setup.exe being at the root of the CD and the first problem.

The fix is now a 2 line change.  The second issue was because the code was
appending an additional '\\' to the license.txt path.  This confused windows 9x
OSes.  The fix is to call AppendBackSlash() that has logic in checking for
trailing '\\'.

Comment 15

[Sean Su]

Attachment: 2nd patch with all fixes.

Comment 16

[bmartin]

I have verified that the 2nd patch works on all Win32 platforms.

Comment 17

[Scott MacGregor]

sr=mscott on the 2nd patch.

Comment 18

[lchiang]

Can you help me to understand?
Does CCK ship from the MN6 branch and include a Netscape 6 RTM build?

Comment 19

[Paul Wyskoczka]

CCK uses the the bits from the Netscape 6 RTM release built on the branch.

Comment 20

[bmartin]

N6 CCK RTM should ship with the Windows 2000-11-08-01-MN6 bits containing Sean's  
fix to this bug.

Comment 21

[Samir Gehani]

r=sgehani for 2nd patch.

Comment 22

[lchiang]

per pdt, marking rtm++.  Once checked in, please specify which build (on MN6
branch) has this fix.  I assume we want this fix to the trunk as well.

granrose, do you suggest we branch or tag or do anything for this fix?

Comment 23

[Daniel (Leaf) Nunes]

I presume we're going to want to make a CCK RTM tag when the time comes for cck
to ship.

Comment 24

[Sean Su]

fix checked into the trunk and Netscape_20000922_BRANCH tag.

Comment 25

[bmartin]

Marking this Verified Fixed in latest N6 CCK RTM build dated: 2000-11-16-21