Provide update locale info in the Android package

VERIFIED FIXED

Status

VERIFIED FIXED
8 years ago
7 years ago

People

(Reporter: alexp, Assigned: alexp)

Tracking

(Blocks: 1 bug)

Trunk
All
Android
Dependency tree / graph
Bug Flags:
in-testsuite ?

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Update service cannot detect the locale due to a missing update.locale file.
(Assignee)

Comment 1

8 years ago
Created attachment 473223 [details] [diff] [review]
Fix
Attachment #473223 - Flags: review?
(Assignee)

Updated

8 years ago
Attachment #473223 - Flags: review? → review?(blassey.bugs)
(Assignee)

Updated

8 years ago
Assignee: nobody → alexp
Blocks: 587384
Status: NEW → ASSIGNED
Comment on attachment 473223 [details] [diff] [review]
Fix


>+        unpackFile(zip, buf, null, "update.locale");

what happens if MOZ_UPDATER isn't defined and update.locale isn't in the .apk?
(Assignee)

Comment 3

8 years ago
(In reply to comment #2)
> >+        unpackFile(zip, buf, null, "update.locale");
> 
> what happens if MOZ_UPDATER isn't defined and update.locale isn't in the .apk?

unpackFile() function writes in the log "Can't find update.locale in /data/app/org.mozilla.fennec.apk" and just returns.
tracking-fennec: --- → ?
Attachment #473223 - Flags: review?(blassey.bugs) → review+
tracking-fennec: ? → 2.0b1+
pushed http://hg.mozilla.org/mozilla-central/rev/be06ea6f6558
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
This issue doesn't occur anymore on the latest Nightly build.

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110914
Firefox/9.0a1 Fennec/9.0a1
Device: HTC Desire
OS: Android 2.2
Status: RESOLVED → VERIFIED
Blocks: 686480
You need to log in before you can comment on or make changes to this bug.