594549 - Provide update locale info in the Android package

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Alex Pakhotin (:alexp)]

Update service cannot detect the locale due to a missing update.locale file.

Comment 1

[Alex Pakhotin (:alexp)]

Attachment: Fix

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 473223 [details] [diff] [review]
Fix


>+        unpackFile(zip, buf, null, "update.locale");

what happens if MOZ_UPDATER isn't defined and update.locale isn't in the .apk?

Comment 3

[Alex Pakhotin (:alexp)]

(In reply to comment #2)
> >+        unpackFile(zip, buf, null, "update.locale");
> 
> what happens if MOZ_UPDATER isn't defined and update.locale isn't in the .apk?

unpackFile() function writes in the log "Can't find update.locale in /data/app/org.mozilla.fennec.apk" and just returns.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/be06ea6f6558

Comment 5

[Catalin Suciu [:csuciu]]

This issue doesn't occur anymore on the latest Nightly build.

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110914
Firefox/9.0a1 Fennec/9.0a1
Device: HTC Desire
OS: Android 2.2