Closed Bug 594551 Opened 9 years ago Closed 9 years ago

Update shows as incompatible in Available Updates pane when the installed version is incompatible

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla2.0b7
Tracking Status
blocking2.0 --- final+

People

(Reporter: mossop, Assigned: mossop)

Details

Attachments

(2 files)

Attached image screenshot
If you have manual updates enabled for an add-on that is incompatible and an update is found then looking in the available updates you'll see the update as incompatible too.
blocking2.0: --- → final+
Whiteboard: [good first bug]
OS: Mac OS X → All
Hardware: x86 → All
Summary: Update shows as incompatible when the installed version is compatible → Update shows as incompatible in Available Updates pane when the installed version is incompatible
Attached patch patch rev 1Splinter Review
We don't actually know whether the upgrade is compatible or blocklisted or anything however we can assume it isn't since the update checker wouldn't have included it as a valid upgrade if there was a problem of some kind. We'll probably need to revisit this if we decide to start offering incompatible upgrades for those with the pref flipped, but that is for another release anyway.
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attachment #480323 - Flags: review?(bmcbride)
Whiteboard: [good first bug] → [has patch][needs review Unfocused]
Attachment #480323 - Flags: review?(bmcbride) → review+
Whiteboard: [has patch][needs review Unfocused] → [has patch][needs-checkin-post-b7]
Fixed: http://hg.mozilla.org/mozilla-central/rev/847aca956eca
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [has patch][needs-checkin-post-b7]
Target Milestone: --- → mozilla2.0b8
Target Milestone: mozilla2.0b8 → mozilla2.0b7
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101105 Firefox/4.0b8pre ID:20101105030743
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.