Closed Bug 594594 Opened 9 years ago Closed 9 years ago

Fix destructuring in narcissus jsparse

Categories

(Other Applications Graveyard :: Narcissus, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: shu, Unassigned)

References

Details

Attachments

(1 file, 2 obsolete files)

Fix destructuring bugs present in jsparse.js
Attached patch Fix (obsolete) — Splinter Review
Attachment #473280 - Flags: review?
Attached patch Fix (obsolete) — Splinter Review
Had typo
Attachment #473280 - Attachment is obsolete: true
Attachment #473280 - Flags: review?
Blocks: 584777
Attached patch FixSplinter Review
Refactor
Attachment #473283 - Attachment is obsolete: true
Attachment #473294 - Flags: review?
Attachment #473294 - Flags: review? → review?(taustin)
Comment on attachment 473294 [details] [diff] [review]
Fix

It looks OK to me.

I did notice that test case ecma_2/Statements/forin-001.js now fails, though I could not spot why.  Might be worth investigating, or failing that, updating narcissus-failures.txt.
Attachment #473294 - Flags: review?(taustin) → review+
Fixed the failing test.

http://hg.mozilla.org/tracemonkey/rev/a3b16f1872a9
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.