594596 - Crash in [@ nsMenuPopupFrame::CreateWidgetForView(nsIView*) ]

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Marcia Knous [:marcia]]

Harvested from crash stats, new to B5. Currently ranks as the #30 top crash on B5, Windows only.

Frame  	Module  	Signature [Expand]  	Source
0 	xul.dll 	nsMenuPopupFrame::CreateWidgetForView 	layout/xul/base/src/nsMenuPopupFrame.cpp:327
1 	xul.dll 	nsMenuPopupFrame::EnsureWidget 	layout/xul/base/src/nsMenuPopupFrame.cpp:262
2 	xul.dll 	nsMenuPopupFrame::InitializePopup 	layout/xul/base/src/nsMenuPopupFrame.cpp:542
3 	xul.dll 	nsXULPopupManager::ShowPopup 	layout/xul/base/src/nsXULPopupManager.cpp:579
4 	xul.dll 	nsPopupBoxObject::OpenPopup 	layout/xul/base/src/nsPopupBoxObject.cpp:134
5 	xul.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:102
6 	xul.dll 	js::InvokeCommon<int > 	js/src/jsinterp.cpp:566
7 	xul.dll 	js::Invoke 	js/src/jsinterp.cpp:696
8 	xul.dll 	js::Interpret 	js/src/jsinterp.cpp:4707
9 	xul.dll 	js::InvokeCommon<int > 	js/src/jsinterp.cpp:577
10 	xul.dll 	js::Invoke 	js/src/jsinterp.cpp:696
11 	xul.dll 	js_fun_call 	js/src/jsfun.cpp:2318
12 	xul.dll 	js::Interpret 	js/src/jsinterp.cpp:4696
13 	xul.dll 	js::InvokeCommon<int > 	js/src/jsinterp.cpp:577
14 	xul.dll 	js::Invoke 	js/src/jsinterp.cpp:696
15 	xul.dll 	js::InternalInvoke 	js/src/jsinterp.cpp:736
16 	xul.dll 	nsXPCWrappedJSClass::CallMethod 	js/src/xpconnect/src/xpcwrappedjsclass.cpp:1688
17 	xul.dll 	nsXPCWrappedJS::CallMethod 	js/src/xpconnect/src/xpcwrappedjs.cpp:570
18 	xul.dll 	PrepareAndDispatch 	xpcom/reflect/xptcall/src/md/win32/xptcstubs.cpp:114
19 	xul.dll 	SharedStub 	xpcom/reflect/xptcall/src/md/win32/xptcstubs.cpp:141
20 	xul.dll 	nsObserverList::NotifyObservers 	xpcom/ds/nsObserverList.cpp:130

Correlation Data:

25% (3/12) vs.   0% (13/4860) [e-mail]
17% (2/12) vs.   1% (42/4860) [e-mail]
17% (2/12) vs.   2% (102/4860) [e-mail]
17% (2/12) vs.   2% (117/4860) [e-mail]
100% (12/12) vs.  87% (4228/4860) [e-mail] (Mozilla Labs - Test Pilot, https://addons.mozilla.org/addon/13661)
33% (4/12) vs.  21% (1031/4860) [e-mail] (Java Quick Starter, http://java.sun.com/javase/downloads/)
33% (4/12) vs.  22% (1089/4860) {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d} (Adblock Plus, https://addons.mozilla.org/addon/1865)
8% (1/12) vs.   0% (1/4860) [e-mail]
8% (1/12) vs.   0% (1/4860) [e-mail]
8% (1/12) vs.   0% (1/4860) [e-mail]
8% (1/12) vs.   0% (1/4860) {e776b7d9-32ee-49e9-888a-8b4283179e53}
8% (1/12) vs.   0% (5/4860) [e-mail] (Add-on Collector, https://addons.mozilla.org/addon/11950)
8% (1/12) vs.   0% (6/4860) [e-mail]
8% (1/12) vs.   0% (8/4860) [e-mail] (SuggestMeYes (Global AutoComplete) - Your personal search suggestions tool (powered by PredictAd), https://addons.mozilla.org/addon/12568)
8% (1/12) vs.   0% (12/4860) [e-mail] (FastestFox - Browse Faster, https://addons.mozilla.org/addon/9825)
8% (1/12) vs.   0% (21/4860) [e-mail] (Cooliris, https://addons.mozilla.org/addon/5579)
8% (1/12) vs.   1% (26/4860) {F17C1572-C9EC-4e5c-A542-D05CBB5C5A08} (Download Accelerator Plus Component, https://addons.mozilla.org/addon/11720)
8% (1/12) vs.   1% (31/4860) {02450954-cdd9-410f-b1da-db804e18c671} (Screengrab, https://addons.mozilla.org/addon/1146)
8% (1/12) vs.   1% (38/4860) [e-mail] (German Dictionary, https://addons.mozilla.org/addon/3077)
8% (1/12) vs.   1% (53/4860) {37fa1426-b82d-11db-8314-0800200c9a66} (WebMail Notifier, https://addons.mozilla.org/addon/4490)
8% (1/12) vs.   1% (54/4860) {01A8CA0A-4C96-465b-A49B-65C46FAD54F9}
8% (1/12) vs.   1% (61/4860) [e-mail] (FoxyProxy, https://addons.mozilla.org/addon/2464)
100% (12/12) vs.  93% (4541/4860) {972ce4c6-7e08-4474-a285-3208198ce6fd} (Default, https://addons.mozilla.org/addon/8150)
8% (1/12) vs.   2% (80/4860) {b9db16a4-6edc-47ec-a1f4-b86292ed211d} (Video DownloadHelper, https://addons.mozilla.org/addon/3006)
8% (1/12) vs.   2% (92/4860) {CAFEEFAC-0016-0000-0020-ABCDEFFEDCBA}
8% (1/12) vs.   2% (118/4860) [e-mail] (Adblock Plus: Element

http://www.webassign.net/v4cgi/extra/marvin.html?mtype=lewis&name=RB_1434372_7_0_1439107 is one URL that comes up, but I wasn't able to trigger a crash on it.

I also installed bandoo and will try reproducing the crash with that addon.

Comment 1

[Marcia Knous [:marcia]]

Forgot to add the link to the crashes: http://tinyurl.com/23h4lr4

Comment 2

[Scoobidiver (away)]

It is #28 top crasher in 4.0b9 for the last week.

Here are some comments:
"i hit shift + ctrl + delete"
"The crash occured when i went to accessed my email from the toolbar."
"It appears to happen when I try to "Create Event" from inside of an email using gmail.com"

Comment 3

[Timothy Nikkel (:tnikkel)]

Attachment: patch

We don't check the return value from CreateWidgetForPopup, and it can fail.

Comment 4

[Timothy Nikkel (:tnikkel)]

Number 27 top crasher on the latest beta, worth taking a patch even if we don't feel super awesome about it.

Comment 5

[Timothy Nikkel (:tnikkel)]

http://hg.mozilla.org/mozilla-central/rev/3f4187103719

Comment 6

[Timothy Nikkel (:tnikkel)]

There've been no crashes since this has landed (and there has been a beta so we got enough volume too), so this looks to be indeed fixed.