594622 - "Assertion failure: unexpected XML node type"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

Reflect.parse("(<x> </x>)()")

Assertion failure: unexpected XML node type, at jsreflect.cpp:2440

This is not a regression; it goes back to the introduction of Reflect.parse.

Comment 1

[Dave Herman [:dherman]]

Attachment: handles TOK_XMLSPACE nodes

A wafer-thin patch -- one line of C++, a handful of lines of JS tests.

Jesse -- thanks, you showed me how to produce certain E4X parse nodes that I hadn't been able to find test cases for.

Dave

Comment 2

[Dave Herman [:dherman]]

http://hg.mozilla.org/tracemonkey/rev/0aac75e6c347

Comment 3

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/0aac75e6c347

Comment 4

[Christian Holler (:decoder)]

E4X has been removed, so we won't add the test.