The default bug view has changed. See this FAQ.

[SeaMonkey 2.1, mochitest-browser-chrome] TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/suite/common/tests/browser/browser_346337.js and browser_466937.js

VERIFIED FIXED in seamonkey2.1b1

Status

SeaMonkey
Testing Infrastructure
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: Bruno 'Aqualon' Escherl, Assigned: Bruno 'Aqualon' Escherl)

Tracking

(Blocks: 1 bug)

Trunk
seamonkey2.1b1
x86
Windows XP
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/suite/common/tests/browser/browser_346337.js | The value for "//input[@type='file'][1]" was correctly restored
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/suite/common/tests/browser/browser_346337.js | The value for "//input[@type='file'][2]" was correctly restored

Seems only to occur on Windows: http://brasstacks.mozilla.com/topfails/test/SeaMonkey?name=chrome://mochikit/content/browser/suite/common/tests/browser/browser_346337.js
(Assignee)

Comment 1

7 years ago
We're missing the test changes from http://hg.mozilla.org/mozilla-central/rev/8d846fde08cb (bug 583863)
Depends on: 583863
Blocks: 583863
No longer depends on: 583863
(Assignee)

Comment 2

7 years ago
Created attachment 473468 [details] [diff] [review]
update tests for refactored input implementation

This are the test changes from bug 583863. The test passes for Linux with and without the patch, so I couldn't test it myself.
Assignee: nobody → aqualon
Status: NEW → ASSIGNED
Attachment #473468 - Flags: review?(neil)
(Assignee)

Comment 3

7 years ago
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/suite/common/tests/browser/browser_466937.js | normal case: file path was correctly preserved - Got , expected /home/user/regular.file

The patch should also fix that test fail.
Summary: [SeaMonkey 2.1, mochitest-browser-chrome] TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/suite/common/tests/browser/browser_346337.js → [SeaMonkey 2.1, mochitest-browser-chrome] TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/suite/common/tests/browser/browser_346337.js and browser_466937.js

Comment 4

7 years ago
Comment on attachment 473468 [details] [diff] [review]
update tests for refactored input implementation

Probably the paths previously used weren't valid on Windows, but it didn't matter because nobody validated them before.
Attachment #473468 - Flags: review?(neil) → review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed

Comment 5

7 years ago
Comment on attachment 473468 [details] [diff] [review]
update tests for refactored input implementation

On second thoughts, r=me if you remove all the calls to createUnique.
(Assignee)

Comment 6

7 years ago
Ok, updating the patch (removing checkin-needed until I have an updated patch)
Keywords: checkin-needed
(Assignee)

Comment 7

7 years ago
Created attachment 473485 [details] [diff] [review]
updated tests without the calls to createUnique

(In reply to comment #5)
> Comment on attachment 473468 [details] [diff] [review]
> update tests for refactored input implementation
> 
> On second thoughts, r=me if you remove all the calls to createUnique.
Taking over r+
Attachment #473468 - Attachment is obsolete: true
Attachment #473485 - Flags: review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Comment on attachment 473485 [details] [diff] [review]
updated tests without the calls to createUnique

Could we use ProfD instead of TmpD, fwiw?
(Assignee)

Comment 9

7 years ago
Does it make any difference?
For future:
http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed

Which you do a decent job of, only comment is (especially if you are already doing a final upload) is specify bug # and specify who reviewed.

That said, pushed as: http://hg.mozilla.org/comm-central/rev/3747f1d60f0a
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Keywords: checkin-needed
(In reply to comment #9)
> Does it make any difference?

It helps to keep TmpD clean, and to put all test files in the same place.

*****

V.Fixed, per
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1284108915.1284114436.22079.gz
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2010/09/10 01:55:15
Status: RESOLVED → VERIFIED
Target Milestone: --- → seamonkey2.1b1
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.